Unity

Merge lp://qastaging/~apinheiro/unity/bug701680 into lp://qastaging/unity

  1. bug701680
  2. Merge into trunk
Proposed by Alejandro Piñeiro
Status: Merged
Merge reported by: Alex Launi
Merged at revision: not available
Proposed branch: lp://qastaging/~apinheiro/unity/bug701680
Merge into: lp://qastaging/unity
Prerequisite: lp://qastaging/~apinheiro/unity/atk-bridge-load
Diff against target: 1864 lines (+1576/-6)
25 files modified
src/Launcher.cpp (+8/-0)
src/Launcher.h (+2/-0)
src/LauncherIcon.cpp (+2/-0)
src/LauncherIcon.h (+1/-0)
src/nux-area-accessible.cpp (+159/-0)
src/nux-area-accessible.h (+57/-0)
src/nux-base-window-accessible.cpp (+161/-0)
src/nux-base-window-accessible.h (+60/-0)
src/nux-layout-accessible.cpp (+153/-0)
src/nux-layout-accessible.h (+60/-0)
src/nux-object-accessible.cpp (+118/-0)
src/nux-object-accessible.h (+60/-0)
src/nux-view-accessible.cpp (+89/-0)
src/nux-view-accessible.h (+60/-0)
src/unity-launcher-accessible.cpp (+155/-0)
src/unity-launcher-accessible.h (+57/-0)
src/unity-launcher-icon-accessible.cpp (+118/-0)
src/unity-launcher-icon-accessible.h (+57/-0)
src/unity-root-accessible.cpp (+50/-6)
src/unity-root-accessible.h (+4/-0)
src/unity-util-accessible.cpp (+8/-0)
src/unity-util-accessible.h (+5/-0)
src/unitya11y.cpp (+114/-0)
src/unitya11y.h (+9/-0)
src/unityshell.cpp (+9/-0)
To merge this branch: bzr merge lp://qastaging/~apinheiro/unity/bug701680
Reviewer Review Type Date Requested Status
Alex Launi (community) Needs Fixing
Review via email: mp+46080@code.qastaging.launchpad.net

Description of the change

  Initial unity/nux atk module implementation

  This commit includes the skeleton implementation for most of the ATK objects,
  that provides the accessibility support for the related nux and unity objects.

To post a comment you must log in.
Revision history for this message
Alex Launi (alexlauni) wrote :

12 +

Added unnecessary whitespace.

I will fix, and merge. Nice work!

review: Approve
Revision history for this message
Alex Launi (alexlauni) wrote :

/home/alex/Projects/unity/bug701680/src/nux-base-window-accessible.cpp: In function ‘gint nux_base_window_accessible_get_n_children(AtkObject*)’:
/home/alex/Projects/unity/bug701680/src/nux-base-window-accessible.cpp:120:25: error: ‘class nux::BaseWindow’ has no member named ‘GetLayout’
/home/alex/Projects/unity/bug701680/src/nux-base-window-accessible.cpp: In function ‘AtkObject* nux_base_window_accessible_ref_child(AtkObject*, gint)’:
/home/alex/Projects/unity/bug701680/src/nux-base-window-accessible.cpp:148:25: error: ‘class nux::BaseWindow’ has no member named ‘GetLayout’
make[2]: *** [CMakeFiles/unityshell.dir/src/nux-base-window-accessible.cpp.o] Error 1
make[1]: *** [CMakeFiles/unityshell.dir/all] Error 2
make: *** [all] Error 2

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.