Merge lp://qastaging/~apinheiro/unity/launcher-icon-also-focused into lp://qastaging/unity
Proposed by
Alejandro Piñeiro
| Status: | Merged | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Approved by: | Mirco Müller | ||||||||
| Approved revision: | no longer in the source branch. | ||||||||
| Merged at revision: | 933 | ||||||||
| Proposed branch: | lp://qastaging/~apinheiro/unity/launcher-icon-also-focused | ||||||||
| Merge into: | lp://qastaging/unity | ||||||||
| Prerequisite: | lp://qastaging/~apinheiro/unity/fix-parent-child-hierarchy | ||||||||
| Diff against target: |
374 lines (+196/-31) 5 files modified
src/Launcher.cpp (+4/-1) src/nux-base-window-accessible.cpp (+2/-0) src/nux-view-accessible.cpp (+7/-0) src/unity-launcher-accessible.cpp (+3/-0) src/unity-launcher-icon-accessible.cpp (+180/-30) |
||||||||
| To merge this branch: | bzr merge lp://qastaging/~apinheiro/unity/launcher-icon-also-focused | ||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Mirco Müller (community) | Approve | ||
| Rodrigo Moya | Pending | ||
|
Review via email:
|
|||
Description of the change
It also sets as focused the launcher icon selected.
Some additional nits:
* Sets a name for the Launcher, so it is announced properly when it gets the focus
* Add a null check on GetSelectedMenuIcon to avoid some crashes.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
With unity trunk and your other branch fix-parent-