Merge lp://qastaging/~ara/mago/firefox_natty into lp://qastaging/~mago-contributors/mago/mago-1.0

Proposed by Ara Pulido
Status: Merged
Merged at revision: 156
Proposed branch: lp://qastaging/~ara/mago/firefox_natty
Merge into: lp://qastaging/~mago-contributors/mago/mago-1.0
Diff against target: 290 lines (+191/-16)
5 files modified
firefox/README (+19/-0)
firefox/firefox_basics.py (+34/-2)
firefox/firefox_basics.xml (+25/-7)
mago/application/firefox.py (+108/-5)
mago/test_suite/firefox.py (+5/-2)
To merge this branch: bzr merge lp://qastaging/~ara/mago/firefox_natty
Reviewer Review Type Date Requested Status
Jean-Baptiste Lallement Approve
Review via email: mp+43176@code.qastaging.launchpad.net

Description of the change

Firefox tests for Natty

Including:

* Open a given URL
* Search a given text in Google
* Open a new tab and close it
* Add a new bookmark and delete it

To post a comment you must log in.
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

With a new profile the default page is displayed and the page requested by the test is opened on another tab.
When the test tries to close firefox, a dialog is displayed saying that more than 1 tab is opened and asking for confirmation before closing.
This dialog makes the test fail.

review: Needs Fixing
Revision history for this message
Ara Pulido (ara) wrote :

Thanks for your review! I will change the setup so it closes the extra tabs when it opens.

Revision history for this message
Ara Pulido (ara) wrote :

/me <3 jibel

154. By Ara Pulido

Fixed setup to leave only one tab to start with

Revision history for this message
Ara Pulido (ara) wrote :

I have fixed the setup method to close all the additional tabs and start fresh with only one.
Can you please rereview?

Thanks!

Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

Rereviewed and looks good. Many thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: