Audience

Merge lp://qastaging/~artem-anufrij/audience/playlist-rewrite into lp://qastaging/~audience-members/audience/trunk

  1. playlist-rewrite
  2. Merge into trunk
Proposed by Artem Anufrij
Status: Rejected
Rejected by: Danielle Foré
Proposed branch: lp://qastaging/~artem-anufrij/audience/playlist-rewrite
Merge into: lp://qastaging/~audience-members/audience/trunk
Diff against target: 1481 lines (+453/-511)
11 files modified
src/CMakeLists.txt (+2/-2)
src/Objects/Video.vala (+7/-2)
src/Widgets/BottomBar.vala (+28/-21)
src/Widgets/EpisodesPage.vala (+23/-5)
src/Widgets/LibraryPage.vala (+5/-4)
src/Widgets/PlayerPage.vala (+42/-82)
src/Widgets/Playlist.vala (+199/-196)
src/Widgets/PlaylistItem.vala (+66/-0)
src/Widgets/PlaylistPopover.vala (+0/-118)
src/Widgets/WelcomePage.vala (+41/-34)
src/Window.vala (+40/-47)
To merge this branch: bzr merge lp://qastaging/~artem-anufrij/audience/playlist-rewrite
Reviewer Review Type Date Requested Status
Jeremy Wootten code, ui, function Needs Fixing
Review via email: mp+307248@code.qastaging.launchpad.net

Description of the change

* Playlist redesign
* Bottom bar: Adden "Next" button
* Playlist: Added "Delete" button
* EpisodesView: Added "Play all" button

To post a comment you must log in.
lp://qastaging/~artem-anufrij/audience/playlist-rewrite updated
680. By Artem Anufrij

no autohide for playlist

681. By Artem Anufrij

* save playlist
* restore playlist
* Welcome button: resume playlist
* Welcome button: replay playlist
* Welcome button: resume last video
* welcome button: replay last video

682. By Artem Anufrij

DnD on welcome screen

683. By Artem Anufrij

visiualisize playlist

Revision history for this message
Artem Anufrij (artem-anufrij) wrote :

Perhaps someone could check this branch.

Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

Conflicts with trunk. I tested after merging and resolving conflicts.

Compilation warnings:
Bottom Bar: playlist_item.added not used.
PlayList::add_from_file - unhandled GLib.Error, misaligned lines

variable name instand_play should be "instant play".
some formatting issues (see inline)

UI:
Add and remove icons not consistent with other elementary apps - use + - buttons at bottom?
Use of trash icon misleading. User might think the original video will be trashed?
Playlist too narrow when empty - need empty message?

FUNCTION:
After adding file(s) they do not appear until playlist hidden/opened or app restarted.

review: Needs Fixing (code, ui, function)
Revision history for this message
Artem Anufrij (artem-anufrij) wrote :

@Jeremy: Dan said I should to break up to work on this branch. Thank you for your time...

Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

Hi Artem.

Do you mean this branch is abandoned/rejected or just on hold? Or it needs
breaking up into smaller branches?

If so it should be marked as "in progress" or be withdrawn...

On 16 December 2016 at 16:40, Artem Anufrij <email address hidden> wrote:

> @Jeremy: Dan said I should to break up to work on this branch. Thank you
> for your time...
> --
> https://code.launchpad.net/~artem-anufrij/audience/
> playlist-rewrite/+merge/307248
> You are reviewing the proposed merge of lp:~artem-anufrij/audience/playlist-rewrite
> into lp:audience.
>

Revision history for this message
Danielle Foré (danrabbit) wrote :

We can probably resume trying to break up this branch into separate PRs on GitHub. Rejecting for now

Unmerged revisions

683. By Artem Anufrij

visiualisize playlist

682. By Artem Anufrij

DnD on welcome screen

681. By Artem Anufrij

* save playlist
* restore playlist
* Welcome button: resume playlist
* Welcome button: replay playlist
* Welcome button: resume last video
* welcome button: replay last video

680. By Artem Anufrij

no autohide for playlist

679. By Artem Anufrij

development

678. By Artem Anufrij

added missing file

677. By Artem Anufrij

begin playlist rewrite

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches