Scratch

Merge lp://qastaging/~artem-anufrij/scratch/Bugfix-1392937 into lp://qastaging/~elementary-apps/scratch/scratch

  1. Bugfix-1392937
  2. Merge into scratch
Proposed by Artem Anufrij
Status: Merged
Merged at revision: 1418
Proposed branch: lp://qastaging/~artem-anufrij/scratch/Bugfix-1392937
Merge into: lp://qastaging/~elementary-apps/scratch/scratch
Diff against target: 146 lines (+53/-28)
2 files modified
plugins/browser-preview/BrowserView.vala (+1/-1)
plugins/browser-preview/browser-preview.vala (+52/-27)
To merge this branch: bzr merge lp://qastaging/~artem-anufrij/scratch/Bugfix-1392937
Reviewer Review Type Date Requested Status
Artem Anufrij (community) merge Needs Information
Raphael Isemann (community) Needs Fixing
Review via email: mp+242842@code.qastaging.launchpad.net

Description of the change

Save the browser preview state for all tabs.

To post a comment you must log in.
Revision history for this message
Raphael Isemann (teemperor) wrote :

When i hit Ctrl+Alt+S (Save as) and save it somewhere else, the refresh stops working. You should check if the URL has changed. Same happens when you open a new tab, type some html and then try to save it somewhere else than the scratch-temp-folder.

review: Needs Fixing
Revision history for this message
Artem Anufrij (artem-anufrij) wrote :

Ok...

This is a small thing.

Revision history for this message
Artem Anufrij (artem-anufrij) wrote :

Oh shit ... I merged it Directly into the scratch... Can it be reversed?

review: Needs Information (merge)
Revision history for this message
Raphael Isemann (teemperor) wrote :

Just make a new merge proposal with the fixes to the ctrl alt s problem.
I'm already in bed and it's easier to just approve a second branch :)
Am 01.12.2014 00:29 schrieb "Artem Anufrij" <email address hidden>:

> Review: Needs Information merge
>
> Oh shit ... I merged it Directly into the scratch... Can it be reversed?
> --
>
> https://code.launchpad.net/~artem-anufrij/scratch/Bugfix-1392937/+merge/242842
> You are reviewing the proposed merge of
> lp:~artem-anufrij/scratch/Bugfix-1392937 into lp:scratch.
>

Revision history for this message
Artem Anufrij (artem-anufrij) wrote :

<ctrl+als+s> was fixed :)

Revision history for this message
Raphael Isemann (teemperor) wrote :

Ok, late review on the already merged branch:

What is "is_app_launch" used for in Scratch.vala? Any reason for that? Looks to me as if you wanted to fix another bug by the way.

Rest of the code seems to be fine.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches