Scratch

Merge lp://qastaging/~artem-anufrij/scratch/Bugfix-1399456 into lp://qastaging/~elementary-apps/scratch/scratch

  1. Bugfix-1399456
  2. Merge into scratch
Proposed by Artem Anufrij
Status: Merged
Approved by: Robert Roth
Approved revision: 1428
Merged at revision: 1427
Proposed branch: lp://qastaging/~artem-anufrij/scratch/Bugfix-1399456
Merge into: lp://qastaging/~elementary-apps/scratch/scratch
Diff against target: 92 lines (+26/-14)
1 file modified
plugins/terminal/terminal.vala (+26/-14)
To merge this branch: bzr merge lp://qastaging/~artem-anufrij/scratch/Bugfix-1399456
Reviewer Review Type Date Requested Status
Robert Roth (community) Approve
Review via email: mp+243863@code.qastaging.launchpad.net

Commit message

Hide terminal toggle button on welcome screen (lp:1399456)

Description of the change

hide terminal toggle button on welcome screen.

To post a comment you must log in.
Revision history for this message
Artem Anufrij (artem-anufrij) wrote :

I have renamed "toolbutton" to "tool_button" like "webbrowser" plugin. This is the reason for "92 lines (+26/-14) 1 file modified". :)

Bugfix code is just only in the lines:

Line 17
and
Line 44 - 53.

lp://qastaging/~artem-anufrij/scratch/Bugfix-1399456 updated
1428. By artem-anufrij

hide toggle button on welcome screen.

Revision history for this message
Robert Roth (evfool) wrote :

Next time you could do the bugfix in a separate commit, and the renaming in another one, and so you will not have to explain what's the bugfix and what's other stuff :) Good job, approving. As danrabbit reported the bug, I guess we don't need a UX review, so I'm approving the merge proposal.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches