Merge lp://qastaging/~artmello/camera-app/camera-app-gridlines into lp://qastaging/camera-app
Proposed by
Arthur Mello
| Status: | Superseded |
|---|---|
| Proposed branch: | lp://qastaging/~artmello/camera-app/camera-app-gridlines |
| Merge into: | lp://qastaging/camera-app |
| Diff against target: |
273 lines (+98/-19) 4 files modified
OptionValueButton.qml (+3/-2) OptionsOverlay.qml (+15/-10) ViewFinderOverlay.qml (+53/-5) ViewFinderView.qml (+27/-2) |
| To merge this branch: | bzr merge lp://qastaging/~artmello/camera-app/camera-app-gridlines |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot | continuous-integration | Needs Fixing | |
| Florian Boucault (community) | Needs Fixing | ||
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2014-12-02.
Commit message
Add gridlines to the viewfinder controlled by a new settings option
Description of the change
Add gridlines to the viewfinder controlled by a new settings option
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Unmerged revisions
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
- making the grid of options 4 columns does not really solve the problem of too many options long term (especially with your other MR coming in); thankfully this was solved already in another branch's commit. I think we should merge the specific commit that fixes it: commit 428 from lp:~fboucault/camera-app/jpeg_quality
Merge command: bzr merge -c428 lp:~fboucault/camera-app/jpeg_quality
- icon "view-grid-
- visually the grid should not have lines around the picture, only the 4 lines inside it; these lines outside are not useful and they create a boxing feel to the UI
- no need to use a Binding object (I understand the consistency reason, but it won't work out for other settings)
- better to not instantiate the Rectangles at all when the grid is disabled; "Repeater.model: settings.
- using Rectangle.border to draw is slightly more expensive than using Rectangle.color