Merge lp://qastaging/~artmello/camera-app/camera-app-self_timer into lp://qastaging/camera-app
Proposed by
Arthur Mello
| Status: | Superseded |
|---|---|
| Proposed branch: | lp://qastaging/~artmello/camera-app/camera-app-self_timer |
| Merge into: | lp://qastaging/camera-app |
| Diff against target: |
666 lines (+353/-46) 6 files modified
OptionValueButton.qml (+3/-2) OptionsOverlay.qml (+15/-10) ViewFinderOverlay.qml (+77/-6) ViewFinderView.qml (+40/-1) assets/self_timer.svg (+177/-0) po/camera-app.pot (+41/-27) |
| To merge this branch: | bzr merge lp://qastaging/~artmello/camera-app/camera-app-self_timer |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot | continuous-integration | Needs Fixing | |
| Florian Boucault (community) | Needs Fixing | ||
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2014-12-02.
Commit message
Add self timer controlled by a new settings option
Description of the change
Add self timer controlled by a new settings option
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Unmerged revisions
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1) countdown label should be bigger: maybe font.pixelSize: units.gu(6)
2) icon "reminder" is not good enough. I asked Matthieu (tiheum) from design to provide a better one. He will base it on the standard industry wise that looks like this: http://
3) settings labels should probably include the word 'seconds': for example "5 seconds" instead of just "5"
4) pot strings should be refreshed (copy over the pot file from the build dir to the source dir)
5) remaining seconds should appear right away when pressing the shoot button instead of a second afterwards
6) it seems there is no need for a start() function in timedShootFeedback; "viewFinderOver
7) it feels like the function timedShoot() should not query the settings but instead take as argument the number of seconds that would be passed by the caller (shoot button)