Merge lp://qastaging/~artmello/gallery-app/gallery-app-avoid_reload_fullscreen_toggle into lp://qastaging/gallery-app

Proposed by Arthur Mello
Status: Merged
Approved by: Florian Boucault
Approved revision: 1239
Merged at revision: 1237
Proposed branch: lp://qastaging/~artmello/gallery-app/gallery-app-avoid_reload_fullscreen_toggle
Merge into: lp://qastaging/gallery-app
Diff against target: 55 lines (+20/-6)
1 file modified
rc/qml/MediaViewer/SingleMediaViewer.qml (+20/-6)
To merge this branch: bzr merge lp://qastaging/~artmello/gallery-app/gallery-app-avoid_reload_fullscreen_toggle
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Florian Boucault (community) Approve
Review via email: mp+269424@code.qastaging.launchpad.net

Commit message

Request only one thumbnail to be displayed at SingleMediaViewer to avoid reloading at fullscreen toggle

Description of the change

Request only one thumbnail to be displayed at SingleMediaViewer to avoid reloading at fullscreen toggle

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
1235. By Arthur Mello

Handle photoviewer resize on desktop

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
1236. By Arthur Mello

Only change the thumbnailer size for resizes bigger than 5%

1237. By Arthur Mello

Set both attributes of size

Revision history for this message
Florian Boucault (fboucault) wrote :

'overview' cannot be referred to as it is not defined in this file. Instead viewer.width and viewer.height should probably be used.

review: Needs Fixing
Revision history for this message
Florian Boucault (fboucault) wrote :

It might be more reliable (and more succint) to do:

    property size thumbSize: Qt.size(overview.width, overview.height)

instead of:

    Component.onCompleted: {
        thumbSize = Qt.size(overview.width, overview.height)
    }

review: Needs Fixing
Revision history for this message
Florian Boucault (fboucault) wrote :

Don't forget ';' a the end of JS lines.

review: Needs Fixing
1238. By Arthur Mello

Does not use overview
Remove unnecessary onCompleted method

1239. By Arthur Mello

Always set thumbSize with a 5% margin

Revision history for this message
Florian Boucault (fboucault) wrote :

Good to go

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
1240. By Arthur Mello

Remove wrong test for video thumbnails

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches