Merge into trunk : gallery-app-fix_1416043 : Code : gallery-app

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot	continuous-integration		Needs Fixing on 2015-02-10
Bill Filler (community)		2015-02-04	Needs Fixing on 2015-02-06
Review via email: mp+248590@code.qastaging.launchpad.net

Revision history for this message

Bill Filler (bfiller) wrote on 2015-02-04:

#

Pretty good, couple of comments:

1) I wouldn't show the check boxes on the date boxes in the Events view as it makes it really hard to read. Instead, in selection mode I'd just make tapping on the date box toggle on/off the selection of all the photos/videos in that Event.

2) I would use a fixed size checkbox so it's the same size for the big and little thumbnails in the Events view. Currently for the big thumbnails it looks quite large and I think it would look better at a fixed size.

3) The toolbar: this applies to camera as well. I think when we are in selection/picker mode and we open an photo, the toolbar should only have the back button and a select action to select the picture. This action will make the photo selected when you return to main select mode. Currently it has a toolbar with all of the actions that the normal photo open has on it, which is weird because it has things like edit, crop, delete, etc. These should all be done from the main selection view I think. The other reason I think it's important to have a select action from the open photo view is because if you open one photo from selection mode and then start swiping, you might find a picture you want to select but there is no way to do this right now. You'd have to return to the main view and try and find that same picture.

4) When we open a picture in select mode, I think the header should be visible by default (it is on camera app), so it's easy to select the photo or go back.

5) This relates to fullscreen mode (so can do in another MR if easier) and comment 4): After playing with this a bit, I think that tapping a photo should open it in fullscreen mode as it does now. However tapping to display the header should leave it in fullscreen mode with the header overlayed (like camera). We should only leave fullscreen mode when returning to one of the main views, Events, Photos, or Albums. Also, we should not reload the photo when toggling the header on/off - currently it seems we are reloading the photo when we show the header.

Pretty good, couple of comments:

1) I wouldn't show the check boxes on the date boxes in the Events view as it makes it really hard to read. Instead, in selection mode I'd just make tapping on the date box toggle on/off the selection of all the photos/videos in that Event.

2) I would use a fixed size checkbox so it's the same size for the big and little thumbnails in the Events view. Currently for the big thumbnails it looks quite large and I think it would look better at a fixed size.

3) The toolbar: this applies to camera as well. I think when we are in selection/picker mode and we open an photo, the toolbar should only have the back button and a select action to select the picture. This action will make the photo selected when you return to main select mode. Currently it has a toolbar with all of the actions that the normal photo open has on it, which is weird because it has things like edit, crop, delete, etc. These should all be done from the main selection view I think. The other reason I think it's important to have a select action from the open photo view is because if you open one photo from selection mode and then start swiping, you might find a picture you want to select but there is no way to do this right now. You'd have to return to the main view and try and find that same picture.

4) When we open a picture in select mode, I think the header should be visible by default (it is on camera app), so it's easy to select the photo or go back.

5) This relates to fullscreen mode (so can do in another MR if easier) and comment 4): After playing with this a bit, I think that tapping a photo should open it in fullscreen mode as it does now. However tapping to display the header should leave it in fullscreen mode with the header overlayed (like camera). We should only leave fullscreen mode when returning to one of the main views, Events, Photos, or Albums. Also, we should not reload the photo when toggling the header on/off - currently it seems we are reloading the photo when we show the header.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-04:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/1109/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~artmello/gallery-app/gallery-app-fix_1416043 updated on 2015-02-06

1145. By Arthur Mello on 2015-02-05: Do not show the check box for event headers
1146. By Arthur Mello on 2015-02-05: Use a fixed size checkbox
1147. By Arthur Mello on 2015-02-05: Send the selection object to the PopupPhotoViewer
1148. By Arthur Mello on 2015-02-05: In selection mode add only one action to the toolbar: toggle selection of the current photo
1149. By Arthur Mello on 2015-02-06: Make the header visible by default when viewing photos in selection mode
1150. By Arthur Mello on 2015-02-06: Stay on fullscreen mode while viewing a photo

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-06:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/1110/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Bill Filler (bfiller) wrote on 2015-02-06:

#

So much better, really close now. A few small things need to be fixed still:

1) Can we change the toolbar icon on the photo view in selection mode as the current ones are a little confusing. I think if the photo is not selected we should show an unchecked box and if it is selected we should show a checked box. What do you think? The cancel looking button was a little confusing.

2) When in picking mode and we open a photo, the header has a back button with "Events" in the title. It should have a back button with "Select" in the title as it does when you are in regular selection mode in the app (not via the picker).

3) In selection mode when you open a picture and then select it from there, then press the back button, can we autoscroll to that picture in the Events view to confirm for the user that it was in fact selected? If this is not possible it's ok, just checking.

4) Fullscreen mode not working correctly for Albums view (works great for other modes). When you open an album by clicking on it, it should open in fullscreen mode and function the same way as opening a picture from Events or Photos view. Currently it's not fullscreen when you open an album or even when you click again on the picture in the album. I think it should be fullscreen like the others even when the header visible, until you return to the main Albums view.

review: Needs Fixing

lp://qastaging/~artmello/gallery-app/gallery-app-fix_1416043 updated on 2015-02-06

1151. By Arthur Mello on 2015-02-06: Change the toggle select icons when in selection mode
1152. By Arthur Mello on 2015-02-06: Change the title when viewing a photo in content hub selection mode
1153. By Arthur Mello on 2015-02-06: Change the icons when viewing a photo

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-06:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/1112/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~artmello/gallery-app/gallery-app-fix_1416043 updated on 2015-02-09

1154. By Arthur Mello on 2015-02-09: Merge with trunk
1155. By Arthur Mello on 2015-02-09: Make the Album Viewer fullscreen

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-09:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/1113/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~artmello/gallery-app/gallery-app-fix_1416043 updated on 2015-02-10

1156. By Arthur Mello on 2015-02-09: Make sure that the last selected item is fully visible on the Photos grid view
1157. By Arthur Mello on 2015-02-09: Make the selected item visible on photos tab when called by content hub

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-10:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/1117/rebuild

review: Needs Fixing (continuous-integration)

gallery-app

Merge lp://qastaging/~artmello/gallery-app/gallery-app-fix_1416043 into lp://qastaging/gallery-app

Commit message

Description of the change

Preview Diff

Subscribers