gallery-app

Merge lp://qastaging/~artmello/gallery-app/gallery-app-handle_svg_files into lp://qastaging/gallery-app

  1. gallery-app-handle_svg_files
  2. Merge into trunk
Proposed by Arthur Mello
Status: Merged
Approved by: Ugo Riboni
Approved revision: 1242
Merged at revision: 1236
Proposed branch: lp://qastaging/~artmello/gallery-app/gallery-app-handle_svg_files
Merge into: lp://qastaging/gallery-app
Diff against target: 519 lines (+329/-41)
7 files modified
debian/control (+1/-0)
src/media-object-factory.cpp (+21/-13)
tests/unittests/mediaobjectfactory/CMakeLists.txt (+3/-12)
tests/unittests/mediaobjectfactory/data/sample02.svg (+295/-0)
tests/unittests/mediaobjectfactory/tst_mediaobjectfactory.cpp (+9/-9)
tests/unittests/stubs/photo_stub.cpp (+0/-6)
tests/unittests/stubs/video_stub.cpp (+0/-1)
To merge this branch: bzr merge lp://qastaging/~artmello/gallery-app/gallery-app-handle_svg_files
Reviewer Review Type Date Requested Status
Ugo Riboni (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+267972@code.qastaging.launchpad.net

Commit message

Do not ignore file if gallery is not able to read its metadata.
Add libqt5svg5 as build dep to run unittests.

Description of the change

Do not ignore file if gallery is not able to read its metadata

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1234
http://jenkins.qa.ubuntu.com/job/gallery-app-ci/1174/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-amd64-ci/102
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-armhf-ci/102
        deb: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-armhf-ci/102/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-i386-ci/102
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/255
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/907
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/721
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/22543

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/1174/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1234
http://jenkins.qa.ubuntu.com/job/gallery-app-ci/1177/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-amd64-ci/105
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-armhf-ci/105
        deb: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-armhf-ci/105/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-i386-ci/105
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/258
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/910
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/724
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/22643

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/1177/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~artmello/gallery-app/gallery-app-handle_svg_files updated
1235. By Arthur Mello

Refactory MediaObjectFactory unittests to test different files format

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1235
http://jenkins.qa.ubuntu.com/job/gallery-app-ci/1179/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-amd64-ci/107/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-armhf-ci/107/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-i386-ci/107/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/260/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/726/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/1179/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~artmello/gallery-app/gallery-app-handle_svg_files updated
1236. By Arthur Mello

Fix build issue

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1236
http://jenkins.qa.ubuntu.com/job/gallery-app-ci/1180/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-amd64-ci/108/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-armhf-ci/108/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-i386-ci/108/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/261
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/912
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/727
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/22657

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/1180/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~artmello/gallery-app/gallery-app-handle_svg_files updated
1237. By Arthur Mello

remove unused warning msg

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1237
http://jenkins.qa.ubuntu.com/job/gallery-app-ci/1181/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-amd64-ci/109/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-armhf-ci/109/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-i386-ci/109/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/262
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/913
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/729
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/22675

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/1181/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~artmello/gallery-app/gallery-app-handle_svg_files updated
1238. By Arthur Mello

Change file output for errors

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1237
http://jenkins.qa.ubuntu.com/job/gallery-app-ci/1182/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-amd64-ci/110/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-armhf-ci/110/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-i386-ci/110/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/263
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/914
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/730
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/22689

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/1182/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1238
http://jenkins.qa.ubuntu.com/job/gallery-app-ci/1183/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-amd64-ci/111/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-armhf-ci/111/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-i386-ci/111/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/264/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/915/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/731
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/22695

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/1183/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~artmello/gallery-app/gallery-app-handle_svg_files updated
1239. By Arthur Mello

Add debug messages to trace issue when building on CI

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1239
http://jenkins.qa.ubuntu.com/job/gallery-app-ci/1184/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-amd64-ci/112/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-armhf-ci/112/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-i386-ci/112/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/265
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/916
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/732
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/22700

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/1184/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~artmello/gallery-app/gallery-app-handle_svg_files updated
1240. By Arthur Mello

More log messages to debug CI issue

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1240
http://jenkins.qa.ubuntu.com/job/gallery-app-ci/1185/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-amd64-ci/113/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-armhf-ci/113/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-i386-ci/113/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/266
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/917
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/733
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/22714

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/1185/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~artmello/gallery-app/gallery-app-handle_svg_files updated
1241. By Arthur Mello

Add missing build requirements

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1241
http://jenkins.qa.ubuntu.com/job/gallery-app-ci/1186/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-amd64-ci/114
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-armhf-ci/114
        deb: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-armhf-ci/114/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-i386-ci/114
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/267
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/918
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/734
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/22730

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/1186/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~artmello/gallery-app/gallery-app-handle_svg_files updated
1242. By Arthur Mello

Remove log msgs

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1242
http://jenkins.qa.ubuntu.com/job/gallery-app-ci/1187/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-amd64-ci/115
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-armhf-ci/115
        deb: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-armhf-ci/115/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-i386-ci/115
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/268
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/919
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/735
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/22735

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/1187/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ugo Riboni (uriboni) wrote :

The code looks good to me. All tests pass on desktop but on device I have problems running this as ap3 froze after running a few of them on krillin.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches