gallery-app

Merge lp://qastaging/~artmello/gallery-app/gallery-app-thumbnailer_wrong_request into lp://qastaging/gallery-app

  1. gallery-app-thumbnailer_wrong_request
  2. Merge into trunk
Proposed by Arthur Mello
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 1231
Merged at revision: 1230
Proposed branch: lp://qastaging/~artmello/gallery-app/gallery-app-thumbnailer_wrong_request
Merge into: lp://qastaging/gallery-app
Diff against target: 87 lines (+20/-15)
3 files modified
rc/qml/Components/MediaGrid.qml (+4/-0)
rc/qml/MediaViewer/SingleMediaViewer.qml (+12/-14)
rc/qml/OrganicView/OrganicMediaList.qml (+4/-1)
To merge this branch: bzr merge lp://qastaging/~artmello/gallery-app/gallery-app-thumbnailer_wrong_request
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+266049@code.qastaging.launchpad.net

Commit message

Fix thumbnail requests with invalid size on Events and Photos tab

Description of the change

Fix thumbnail requests with invalid size on Events and Photos tab

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1227
http://jenkins.qa.ubuntu.com/job/gallery-app-ci/1167/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-amd64-ci/95
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-armhf-ci/95
        deb: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-armhf-ci/95/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-i386-ci/95
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/247
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/899
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/698
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/22158

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/1167/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~artmello/gallery-app/gallery-app-thumbnailer_wrong_request updated
1228. By Arthur Mello

Make sure we are not requesting video thumbnails as 0

1229. By Arthur Mello

Fix typo

1230. By Arthur Mello

Link to bug

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1230
http://jenkins.qa.ubuntu.com/job/gallery-app-ci/1168/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-amd64-ci/96
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-armhf-ci/96
        deb: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-armhf-ci/96/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-i386-ci/96
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/248
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/900
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/699
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/22159

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/1168/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~artmello/gallery-app/gallery-app-thumbnailer_wrong_request updated
1231. By Arthur Mello

Do not request tthumbanils when going fullscreen

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1231
http://jenkins.qa.ubuntu.com/job/gallery-app-ci/1169/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-amd64-ci/97
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-armhf-ci/97
        deb: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-armhf-ci/97/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-i386-ci/97
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/249
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/901
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/700
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/22181

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/1169/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches