Ubuntu Calendar App

Merge lp://qastaging/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1544582 into lp://qastaging/ubuntu-calendar-app

  1. ubuntu-calendar-app-fix_1544582
  2. Merge into trunk
Proposed by Arthur Mello
Status: Merged
Approved by: Renato Araujo Oliveira Filho
Approved revision: 791
Merged at revision: 800
Proposed branch: lp://qastaging/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1544582
Merge into: lp://qastaging/ubuntu-calendar-app
Diff against target: 185 lines (+45/-25)
6 files modified
EventBubble.qml (+9/-4)
EventDetails.qml (+16/-13)
NewEvent.qml (+5/-2)
TimeLineBase.qml (+12/-3)
TimeLineBaseComponent.qml (+1/-1)
calendar_canvas.js (+2/-2)
To merge this branch: bzr merge lp://qastaging/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1544582
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Approve
Renato Araujo Oliveira Filho (community) Approve
Review via email: mp+289278@code.qastaging.launchpad.net

Commit message

Add support to create and import/export events with start date equals to end date

Description of the change

Add support to create and import/export events with start date equals to end date

To post a comment you must log in.
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

Whats happen on NewEvent page? Do we need something special when editing a event with end date null?

review: Needs Information
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

Got this warning: file:///opt/click.ubuntu.com/com.ubuntu.calendar/0.5.788/NewEvent.qml:341: TypeError: Cannot call method 'getTime' of undefined

Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

Creating a event on google and syncing it with the device works nice. But the event appears dimmed like it was a event in the past.

How to reproduce:
1 - Create a event on google at current time + 1 h
2 - From calendar app start the sync

Expected:
The event appears in the view with the calendar color

Current:
The event appears in the view dimmed "like past events"

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:790
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/794/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/796/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/794/rebuild

review: Approve (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:791
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/797/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/803/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/797/rebuild

review: Approve (continuous-integration)
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

works nice

review: Approve
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Autolanding.
Unapproved changes made after approval.
https://core-apps-jenkins.ubuntu.com/job/calendar-app-autolanding/265/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/5701/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

approved

review: Approve
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: