Ubuntu Calendar App

Merge lp://qastaging/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1563316 into lp://qastaging/ubuntu-calendar-app

  1. ubuntu-calendar-app-fix_1563316
  2. Merge into trunk
Proposed by Arthur Mello
Status: Merged
Approved by: Renato Araujo Oliveira Filho
Approved revision: 814
Merged at revision: 811
Proposed branch: lp://qastaging/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1563316
Merge into: lp://qastaging/ubuntu-calendar-app
Diff against target: 397 lines (+256/-21)
4 files modified
EventBubble.qml (+42/-15)
TimeLineBaseComponent.qml (+1/-1)
tests/unittests/tst_calendar_canvas.qml (+5/-5)
tests/unittests/tst_event_bubble.qml (+208/-0)
To merge this branch: bzr merge lp://qastaging/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1563316
Reviewer Review Type Date Requested Status
Renato Araujo Oliveira Filho (community) Approve
Jenkins Bot continuous-integration Approve
Review via email: mp+290317@code.qastaging.launchpad.net

Commit message

Change Event Bubble style depending if user is attending the event following design spec

Description of the change

Change Event Bubble style depending if user is attending the event following design spec

Testing
=======
Import from google account events with different attendee status (Yes/Maybe/No) both for future and past end times. Make sure that the event bubble is updated as expected

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:809
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/812/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/831/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/812/rebuild

review: Approve (continuous-integration)
lp://qastaging/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1563316 updated
810. By Arthur Mello

Fix when requesting owner status for local events

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:810
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/813/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/832/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/813/rebuild

review: Approve (continuous-integration)
lp://qastaging/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1563316 updated
811. By Arthur Mello

Fix calendar canvas unittest

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:811
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/814/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/835/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/814/rebuild

review: Approve (continuous-integration)
lp://qastaging/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1563316 updated
812. By Arthur Mello

Merge with trunk

813. By Arthur Mello

Add unit test

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:813
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/815/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/838/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/815/rebuild

review: Approve (continuous-integration)
lp://qastaging/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1563316 updated
814. By Arthur Mello

Add border with same color as collection for unaswered events

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:814
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/816/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/839/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/816/rebuild

review: Approve (continuous-integration)
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

great job.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: