Ubuntu Calendar App

Merge lp://qastaging/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1564398 into lp://qastaging/ubuntu-calendar-app

  1. ubuntu-calendar-app-fix_1564398
  2. Merge into trunk
Proposed by Arthur Mello
Status: Merged
Approved by: Renato Araujo Oliveira Filho
Approved revision: 814
Merged at revision: 816
Proposed branch: lp://qastaging/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1564398
Merge into: lp://qastaging/ubuntu-calendar-app
Diff against target: 205 lines (+82/-91)
4 files modified
EventReminder.qml (+0/-82)
EventRepetition.qml (+1/-1)
NewEvent.qml (+18/-8)
OptionSelectorPage.qml (+63/-0)
To merge this branch: bzr merge lp://qastaging/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1564398
Reviewer Review Type Date Requested Status
Renato Araujo Oliveira Filho (community) Approve
Jenkins Bot continuous-integration Approve
Review via email: mp+290745@code.qastaging.launchpad.net

Commit message

Refactor on the EventReminder option selector page
Change EventRepetition page to show all options when OptionSelector is expanded

Description of the change

Refactor on the EventReminder option selector page
Change EventRepetition page to show all options when OptionSelector is expanded

This is not a complete solution for bug #1564398 but implements some changes to reduce the issue

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:812
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/818/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/841/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/818/rebuild

review: Approve (continuous-integration)
lp://qastaging/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1564398 updated
813. By Arthur Mello

Merge with trunk

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:813
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/821/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/845/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/821/rebuild

review: Approve (continuous-integration)
lp://qastaging/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1564398 updated
814. By Arthur Mello

Stop using Ubuntu.Components.ListItems

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:814
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/824/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/849/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/824/rebuild

review: Approve (continuous-integration)
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: