Ubuntu Push Notifications

Merge lp://qastaging/~artmello/ubuntu-push/ubuntu-push-use_fallback_for_nil_sound_vibe into lp://qastaging/ubuntu-push

ubuntu-push-use_fallback_for_nil_sound_vibe
Merge into trunk

Proposed by Arthur Mello on 2016-08-17

Status:	Approved
Approved by:	Bill Filler on 2016-08-25
Approved revision:	177
Proposed branch:	lp://qastaging/~artmello/ubuntu-push/ubuntu-push-use_fallback_for_nil_sound_vibe
Merge into:	lp://qastaging/ubuntu-push
Diff against target:	113 lines (+26/-9) 5 files modified debian/rules (+1/-1) launch_helper/helper_output.go (+4/-2) launch_helper/helper_output_test.go (+12/-3) sounds/sounds.go (+8/-2) sounds/sounds_test.go (+1/-1)
To merge this branch:	bzr merge lp://qastaging/~artmello/ubuntu-push/ubuntu-push-use_fallback_for_nil_sound_vibe
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Jonas G. Drange (community)		2016-08-17	Approve on 2016-08-25
system-apps-ci-bot	continuous-integration		Needs Fixing on 2016-08-25
Review via email: mp+303134@code.qastaging.launchpad.net

Commit message

Use fallback when notification has nil RawSound/RawVibration

Description of the change

Use fallback when notification has nil RawSound/RawVibration

Revision history for this message

system-apps-ci-bot (system-apps-ci-bot) wrote on 2016-08-17:

FAILED: Continuous integration, rev:169
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-push-ci/26/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1223/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1223
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/1097/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial+overlay/1097/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=yakkety/1097/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-push-ci/26/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~artmello/ubuntu-push/ubuntu-push-use_fallback_for_nil_sound_vibe updated on 2016-08-23

170. By Arthur Mello on 2016-08-23: Change to use GStreamer to play audio on the Sound Presenter

Revision history for this message

system-apps-ci-bot (system-apps-ci-bot) wrote on 2016-08-23:

FAILED: Continuous integration, rev:170
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-push-ci/27/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1274/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1274
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/1140/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial+overlay/1140/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=yakkety/1140/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-push-ci/27/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~artmello/ubuntu-push/ubuntu-push-use_fallback_for_nil_sound_vibe updated on 2016-08-23

171. By Arthur Mello on 2016-08-23: Add missing build deps

Revision history for this message

system-apps-ci-bot (system-apps-ci-bot) wrote on 2016-08-23:

FAILED: Continuous integration, rev:171
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-push-ci/28/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1276/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1276
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/1142/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial+overlay/1142/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=yakkety/1142/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-push-ci/28/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~artmello/ubuntu-push/ubuntu-push-use_fallback_for_nil_sound_vibe updated on 2016-08-23

172. By Arthur Mello on 2016-08-23: Disable tests bases on aplay player

Revision history for this message

system-apps-ci-bot (system-apps-ci-bot) wrote on 2016-08-23:

FAILED: Continuous integration, rev:172
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-push-ci/29/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1277/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1277
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/1143/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial+overlay/1143/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=yakkety/1143/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-push-ci/29/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~artmello/ubuntu-push/ubuntu-push-use_fallback_for_nil_sound_vibe updated on 2016-08-23

173. By Arthur Mello on 2016-08-23: Remove unused imports

Revision history for this message

system-apps-ci-bot (system-apps-ci-bot) wrote on 2016-08-23:

FAILED: Continuous integration, rev:173
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-push-ci/30/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1278/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1278
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/1144/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial+overlay/1144/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=yakkety/1144/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-push-ci/30/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~artmello/ubuntu-push/ubuntu-push-use_fallback_for_nil_sound_vibe updated on 2016-08-24

174. By Arthur Mello on 2016-08-24: Undo the changes to use GStreamer since that is not fully support on all build archs
175. By Arthur Mello on 2016-08-24: Prioritize fallback audio file defined on ubuntu-push config over the accounts one

Revision history for this message

system-apps-ci-bot (system-apps-ci-bot) wrote on 2016-08-24:

FAILED: Continuous integration, rev:175
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-push-ci/31/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1300/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1300
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/1165/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial+overlay/1165/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=yakkety/1165/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-push-ci/31/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~artmello/ubuntu-push/ubuntu-push-use_fallback_for_nil_sound_vibe updated on 2016-08-24

176. By Arthur Mello on 2016-08-24: Fix test

Revision history for this message

system-apps-ci-bot (system-apps-ci-bot) wrote on 2016-08-24:

FAILED: Continuous integration, rev:176
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-push-ci/32/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1301/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1301
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/1166/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial+overlay/1166/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=yakkety/1166/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-push-ci/32/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~artmello/ubuntu-push/ubuntu-push-use_fallback_for_nil_sound_vibe updated on 2016-08-25

177. By Arthur Mello on 2016-08-25: Disable tests on arm64

Revision history for this message

system-apps-ci-bot (system-apps-ci-bot) wrote on 2016-08-25:

FAILED: Continuous integration, rev:177
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-push-ci/33/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1304/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1304
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/1169/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial+overlay/1169/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=yakkety/1169/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-push-ci/33/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Jonas G. Drange (jonas-drange) wrote on 2016-08-25:

LGTM, thanks!

review: Approve

Unmerged revisions

177. By Arthur Mello on 2016-08-25: Disable tests on arm64
176. By Arthur Mello on 2016-08-24: Fix test
175. By Arthur Mello on 2016-08-24: Prioritize fallback audio file defined on ubuntu-push config over the accounts one
174. By Arthur Mello on 2016-08-24: Undo the changes to use GStreamer since that is not fully support on all build archs
173. By Arthur Mello on 2016-08-23: Remove unused imports
172. By Arthur Mello on 2016-08-23: Disable tests bases on aplay player
171. By Arthur Mello on 2016-08-23: Add missing build deps
170. By Arthur Mello on 2016-08-23: Change to use GStreamer to play audio on the Sound Presenter
169. By Arthur Mello on 2016-08-17: Use fallback when notification has nil RawSound/RawVibration

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes:

Arthur Mello

Stuart Bishop

Ubuntu Push Hackers