Ubuntu UI Toolkit Extras

Merge lp://qastaging/~artmello/ubuntu-ui-extras/ubuntu-ui-extras-videoplayer-components into lp://qastaging/ubuntu-ui-extras

  1. ubuntu-ui-extras-videoplayer-components
  2. Merge into trunk
Proposed by Arthur Mello
Status: Needs review
Proposed branch: lp://qastaging/~artmello/ubuntu-ui-extras/ubuntu-ui-extras-videoplayer-components
Merge into: lp://qastaging/ubuntu-ui-extras
Diff against target: 1320 lines (+1258/-0)
11 files modified
modules/Ubuntu/Components/Extras/CMakeLists.txt (+1/-0)
modules/Ubuntu/Components/Extras/MediaPlayer/AbstractPlayer.qml (+213/-0)
modules/Ubuntu/Components/Extras/MediaPlayer/CMakeLists.txt (+2/-0)
modules/Ubuntu/Components/Extras/MediaPlayer/ContentPopover.qml (+63/-0)
modules/Ubuntu/Components/Extras/MediaPlayer/PlayerActionBar.qml (+83/-0)
modules/Ubuntu/Components/Extras/MediaPlayer/PlayerActionsDrawer.qml (+124/-0)
modules/Ubuntu/Components/Extras/MediaPlayer/PlayerPanel.qml (+111/-0)
modules/Ubuntu/Components/Extras/MediaPlayer/TimeLine.qml (+98/-0)
modules/Ubuntu/Components/Extras/MediaPlayer/VideoPlayerToolbar.qml (+128/-0)
modules/Ubuntu/Components/Extras/VideoPlayer.qml (+434/-0)
modules/Ubuntu/Components/Extras/qmldir (+1/-0)
To merge this branch: bzr merge lp://qastaging/~artmello/ubuntu-ui-extras/ubuntu-ui-extras-videoplayer-components
Reviewer Review Type Date Requested Status
system-apps-ci-bot continuous-integration Needs Fixing
PS Jenkins bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+280450@code.qastaging.launchpad.net

Commit message

Add VideoPlayer Component

Description of the change

Add VideoPlayer Component

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:73
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-ci/76/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-amd64-ci/37
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-armhf-ci/37
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-armhf-ci/37/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-ui-extras-ci/76/rebuild

review: Approve (continuous-integration)
Reply
lp://qastaging/~artmello/ubuntu-ui-extras/ubuntu-ui-extras-videoplayer-components updated
74. By Arthur Mello

Add property to set title
Add back action

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:74
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-ci/77/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-amd64-ci/38
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-armhf-ci/38
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-armhf-ci/38/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-ui-extras-ci/77/rebuild

review: Approve (continuous-integration)
Reply
lp://qastaging/~artmello/ubuntu-ui-extras/ubuntu-ui-extras-videoplayer-components updated
75. By Arthur Mello

Fix video replay after ending

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:75
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-ci/78/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-amd64-ci/39
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-armhf-ci/39
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-armhf-ci/39/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-ui-extras-ci/78/rebuild

review: Approve (continuous-integration)
Reply
lp://qastaging/~artmello/ubuntu-ui-extras/ubuntu-ui-extras-videoplayer-components updated
76. By Arthur Mello

Merge with trunk

77. By Arthur Mello

Make sure to stop player before closing the stream

78. By Arthur Mello

Move title bar to a loader so it will not show up during component loading

79. By Arthur Mello

Fix toolbars open/close

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:79
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-ci/82/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-amd64-ci/43
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-armhf-ci/43
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-armhf-ci/43/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-ui-extras-ci/82/rebuild

review: Approve (continuous-integration)
Reply
lp://qastaging/~artmello/ubuntu-ui-extras/ubuntu-ui-extras-videoplayer-components updated
80. By Arthur Mello

Changes to botton bar:
- Change Share button for a Play/Pause one
- Add more vertical space between time labels and scrubber
- Add button anchored to the right to toggle fullscreen

81. By Arthur Mello

Changes to titlebar
- Add share/save buttons by default
- Application can control if share/save buttons are visible
- Application can add it owns actions to the titlebar

82. By Arthur Mello

Fix toolbar actions issue

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:82
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-ci/83/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-amd64-ci/44
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-armhf-ci/44
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-armhf-ci/44/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-ui-extras-ci/83/rebuild

review: Approve (continuous-integration)
Reply
lp://qastaging/~artmello/ubuntu-ui-extras/ubuntu-ui-extras-videoplayer-components updated
83. By Arthur Mello

Make sure the dismissBars timer is not triggered twice

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:83
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-ci/84/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-amd64-ci/45
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-armhf-ci/45
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-armhf-ci/45/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-ui-extras-ci/84/rebuild

review: Approve (continuous-integration)
Reply
lp://qastaging/~artmello/ubuntu-ui-extras/ubuntu-ui-extras-videoplayer-components updated
84. By Arthur Mello

Do not trigger the same action twice

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:84
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-ci/85/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-amd64-ci/46
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-armhf-ci/46
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-armhf-ci/46/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-ui-extras-ci/85/rebuild

review: Approve (continuous-integration)
Reply
lp://qastaging/~artmello/ubuntu-ui-extras/ubuntu-ui-extras-videoplayer-components updated
85. By Arthur Mello

Fix Share/Save actions so the ContentPeerPicker can be called from inside the component

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:85
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-ci/86/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-amd64-ci/47
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-armhf-ci/47
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-armhf-ci/47/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-ui-extras-ci/86/rebuild

review: Approve (continuous-integration)
Reply
lp://qastaging/~artmello/ubuntu-ui-extras/ubuntu-ui-extras-videoplayer-components updated
86. By Arthur Mello

Fix behavior when the Video ends

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:86
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-ci/87/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-amd64-ci/48
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-armhf-ci/48
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-armhf-ci/48/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-ui-extras-ci/87/rebuild

review: Approve (continuous-integration)
Reply
lp://qastaging/~artmello/ubuntu-ui-extras/ubuntu-ui-extras-videoplayer-components updated
87. By Arthur Mello

Handle fullscreen propoty inside video player

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:87
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-ci/89/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-amd64-ci/50
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-armhf-ci/50
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-armhf-ci/50/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-ui-extras-ci/89/rebuild

review: Approve (continuous-integration)
Reply
lp://qastaging/~artmello/ubuntu-ui-extras/ubuntu-ui-extras-videoplayer-components updated
88. By Arthur Mello

Fix typo

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:88
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-ci/90/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-amd64-ci/51
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-armhf-ci/51
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-armhf-ci/51/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-ui-extras-ci/90/rebuild

review: Approve (continuous-integration)
Reply
lp://qastaging/~artmello/ubuntu-ui-extras/ubuntu-ui-extras-videoplayer-components updated
89. By Arthur Mello

Add elite to title bar text

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:89
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-ci/91/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-amd64-ci/52
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-armhf-ci/52
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-armhf-ci/52/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-ui-extras-ci/91/rebuild

review: Approve (continuous-integration)
Reply
lp://qastaging/~artmello/ubuntu-ui-extras/ubuntu-ui-extras-videoplayer-components updated
90. By Arthur Mello

Merge with trunk

91. By Arthur Mello

Change component API following review

92. By Arthur Mello

Make fullscreen a rdonly property

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:91
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-ci/92/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-amd64-ci/53
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-armhf-ci/53
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-armhf-ci/53/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-ui-extras-ci/92/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:92
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-ci/93/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-amd64-ci/54
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-armhf-ci/54
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-extras-vivid-armhf-ci/54/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-ui-extras-ci/93/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :
Download full text (3.3 KiB)

FAILED: Continuous integration, rev:92
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-ui-extras-ci/1/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build/640
    FAILURE: https://jenkins.canonical.com/system-apps/job/test-0-autopkgtest/label=phone-armhf,release=vivid+overlay,testname=default/84/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/test-0-autopkgtest/label=phone-armhf,release=xenial+overlay,testname=default/84/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/test-0-autopkgtest/label=phone-armhf,release=yakkety,testname=default/84/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/640
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/607
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial+overlay/607
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=yakkety/607
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/599
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/599/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/599
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/599/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/599
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/599/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/599
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/599/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/599
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/599/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/599
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/599/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/599
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/599/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/599
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/599/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/599
        deb: https://jenkins.canonical.com/system-apps/job/build...

Read more...

review: Needs Fixing (continuous-integration)
Reply

Unmerged revisions

92. By Arthur Mello

Make fullscreen a rdonly property

91. By Arthur Mello

Change component API following review

90. By Arthur Mello

Merge with trunk

89. By Arthur Mello

Add elite to title bar text

88. By Arthur Mello

Fix typo

87. By Arthur Mello

Handle fullscreen propoty inside video player

86. By Arthur Mello

Fix behavior when the Video ends

85. By Arthur Mello

Fix Share/Save actions so the ContentPeerPicker can be called from inside the component

84. By Arthur Mello

Do not trigger the same action twice

83. By Arthur Mello

Make sure the dismissBars timer is not triggered twice

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches