Merge into trunk : TIME_WAIT-before-fastmodel-start : Code : LAVA Dispatcher

Status:

Rejected

Rejected by:

Neil Williams on 2014-07-02

Proposed branch:

lp://qastaging/~asac/lava-dispatcher/TIME_WAIT-before-fastmodel-start

Merge into:

lp://qastaging/lava-dispatcher

Prerequisite:

lp://qastaging/~asac/lava-dispatcher/logged-commands-getstatusoutput-wrapper-util

Diff against target:

31 lines (+7/-0)

1 file modified

lava_dispatcher/client/fastmodel.py (+7/-0)

To merge this branch:

bzr merge lp://qastaging/~asac/lava-dispatcher/TIME_WAIT-before-fastmodel-start

High

Won't Fix

Link a bug report

Reviewer	Review Type	Date Requested	Status
Michael Hudson-Doyle (community)		2012-08-09	Approve on 2012-08-09
Review via email: mp+119032@code.qastaging.launchpad.net

Description of the change

workaround fix for TIME_WAIT fast model bustage as discussed in: https://bugs.launchpad.net/lava-dispatcher/+bug/1034809

here we wait till TIME_WAIT is gone, which will fix that we sometimes cant connect adb after rebooting fastmodel.

see https://code.launchpad.net/~asac/lava-dispatcher/logged-commands-getstatusoutput-wrapper-util/+merge/119029 for prereq merge proposal.

Revision history for this message

Alexander Sack (asac) wrote on 2012-08-09:

#

example log with this patch applied:

<LAVA_DISPATCHER>2012-08-09 08:32:57 PM INFO: Execute adb command on host: adb disconnect 127.0.0.1

<LAVA_DISPATCHER>2012-08-09 08:32:57 PM INFO: [ACTION-E] lava_android_test_run is finished successfully.
<LAVA_DISPATCHER>2012-08-09 08:32:57 PM INFO: [ACTION-B] boot_linaro_android_image is started with {}
<LAVA_DISPATCHER>2012-08-09 08:32:58 PM INFO: NOW: waiting for TIME_WAIT 5555 socket to finish - see lp:1034809
<LAVA_DISPATCHER>2012-08-09 08:32:58 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:01 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:04 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:07 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:10 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:13 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:16 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:19 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:22 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:25 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:28 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:31 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:34 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:37 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:40 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:43 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:46 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:49 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:52 PM INFO: launching fastmodel with command u"/home/ubuntu/RTSM_A15-A7x14_VE/Linux64_RTSM_VE_Cortex-A15x4-A7x4/RTSM_VE_Cortex-A15x4-A7x4 -a coretile.cluster0.*=/linaro/images/tmp/tmp9FwvnR/linux-system-ISW.axf -C motherboard.smsc_91c111.enabled=1 -C motherboard.hostbridge.userNetworking=1 -C motherboard.mmc.p_mmc_file=/linaro/images/tmp/tmp9FwvnR/android.img -C coretile.cache_state_modelled=0 -C coretile.cluster0.cpu0.semihosting-enable=1 -C motherboard.hostbridge.userNetPorts='5555=5555'"

... in this case it wouldn't have managed to reconnect to adb.

example log with this patch applied:

<LAVA_DISPATCHER>2012-08-09 08:32:57 PM INFO: Execute adb command on host: adb disconnect 127.0.0.1

<LAVA_DISPATCHER>2012-08-09 08:32:57 PM INFO: [ACTION-E] lava_android_test_run is finished successfully.
<LAVA_DISPATCHER>2012-08-09 08:32:57 PM INFO: [ACTION-B] boot_linaro_android_image is started with {}
<LAVA_DISPATCHER>2012-08-09 08:32:58 PM INFO: NOW: waiting for TIME_WAIT 5555 socket to finish - see lp:1034809
<LAVA_DISPATCHER>2012-08-09 08:32:58 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:01 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:04 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:07 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:10 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:13 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:16 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:19 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:22 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:25 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:28 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:31 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:34 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:37 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:40 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:43 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:46 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:49 PM INFO: waiting for TIME_WAIT 5555 socket to finish
<LAVA_DISPATCHER>2012-08-09 08:33:52 PM INFO: launching fastmodel with command u"/home/ubuntu/RTSM_A15-A7x14_VE/Linux64_RTSM_VE_Cortex-A15x4-A7x4/RTSM_VE_Cortex-A15x4-A7x4 -a coretile.cluster0.*=/linaro/images/tmp/tmp9FwvnR/linux-system-ISW.axf -C motherboard.smsc_91c111.enabled=1 -C motherboard.hostbridge.userNetworking=1 -C motherboard.mmc.p_mmc_file=/linaro/images/tmp/tmp9FwvnR/android.img -C coretile.cache_state_modelled=0 -C coretile.cluster0.cpu0.semihosting-enable=1 -C motherboard.hostbridge.userNetPorts='5555=5555'"

... in this case it wouldn't have managed to reconnect to adb.

Revision history for this message

Michael Hudson-Doyle (mwhudson) wrote on 2012-08-09:

#

I don't really understand why the socket ends up in TIME_WAIT and the grep is a bit ugly, but I guess it solves the problem...

review: Approve

Revision history for this message

Alexander Sack (asac) wrote on 2012-08-09:

#

thanks. its the right decision to approve this. its a workaound until fastmodel folks fix their underlying issue (see bug); hence it doesnt need to be beautiful und gettng the same info from kernel directly that netstat gives us will also not be much nicer :)

Revision history for this message

Alexander Sack (asac) wrote on 2012-08-09:

#

please also sign off the prerequisite branch... otherwise i will just merge it along... :)

Unmerged revisions

368. By Alexander Sack on 2012-08-09: implement workaround for lp:1034809 - wait till socket is released from TIME_WAIT state before launching fast model
367. By Alexander Sack on 2012-08-09: add logged commands.getstatuswrapper (logging_commands__getstatusoutput) to utils.py

LAVA Dispatcher

Merge lp://qastaging/~asac/lava-dispatcher/TIME_WAIT-before-fastmodel-start into lp://qastaging/lava-dispatcher

Commit message

Description of the change

Unmerged revisions

Preview Diff

Subscribers