Linaro Android Build Tools

Merge lp://qastaging/~asac/linaro-android-build-tools/lava-test-plan-reboot-token into lp://qastaging/linaro-android-build-tools

  1. lava-test-plan-reboot-token
  2. Merge into trunk
Proposed by Alexander Sack
Status: Merged
Merged at revision: 489
Proposed branch: lp://qastaging/~asac/linaro-android-build-tools/lava-test-plan-reboot-token
Merge into: lp://qastaging/linaro-android-build-tools
Diff against target: 50 lines (+20/-13)
1 file modified
build-scripts/post-build-lava.py (+20/-13)
To merge this branch: bzr merge lp://qastaging/~asac/linaro-android-build-tools/lava-test-plan-reboot-token
Reviewer Review Type Date Requested Status
Yongqin Liu (community) Approve
Milo Casagrande (community) Approve
vishal Pending
Paul Sokolovsky Pending
Review via email: mp+110505@code.qastaging.launchpad.net

Description of the change

as part of the ongoing benchmarking effort, quiescing the system, we want to have more control as of when a system reboots.

This change aims at providing a special token for LAVA_TEST_PLAN that allows the build owner to encode a reboot in between test actions.

e.g. LAVA_TEST_PLAN=bench-system-prep,^,sleep,skia,skia,skia,^,sleep,skia,skia,skia

part of http://cards.linaro.org/browse/CARD-134

To post a comment you must log in.
Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

One comment I would have is that "^" looks rather magic, why not just "reboot"?

Revision history for this message
Alexander Sack (asac) wrote :

oh ... and if there are syntax fixes, please go ahead and fix them while merging if possible... if you need anything, remember to ping me on IRC!

Revision history for this message
Alexander Sack (asac) wrote :

> One comment I would have is that "^" looks rather magic, why not just
> "reboot"?

reboot looks syntactically not special enough and might conflict with a test name :). I agree that ^ looks magic.

So how about [reboot] or <reboot> ? if so, feel free to pick whatever you prefer during merge.

Revision history for this message
Alexander Sack (asac) wrote :

oh ... i would love to run a test that reboots today as i am landing a bunch of other things for benchmarking and it would give me a great WE :).

Revision history for this message
Milo Casagrande (milo) wrote :

Hello there,

thanks for working on this! The merge proposal looks definitely good to me, as suggested before I would switch to use "[reboot]", or to maintain consistency with the rest of the values something like: system-restart, system-reboot, board-reboot, or similar.

review: Approve
Revision history for this message
Yongqin Liu (liuyq0307) wrote :

seems OK to me.
and I am with system-reboot

review: Approve
Revision history for this message
Alexander Sack (asac) wrote :

I don't care that much ... just remember that the other names refer to actual TESTS... while this thing is a special instruction. so I think having a slightly justified syntax is ok, but I won't hold back ... my favorit is [system-reboot] ... an dyes, go for whatever you decide and adjust during commit. thanks

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches