Linaro Android Build Tools

Merge lp://qastaging/~asac/linaro-android-build-tools/select-lava-device-through-build-config into lp://qastaging/linaro-android-build-tools

  1. select-lava-device-through-build-config
  2. Merge into trunk
Proposed by Alexander Sack
Status: Merged
Merged at revision: 467
Proposed branch: lp://qastaging/~asac/linaro-android-build-tools/select-lava-device-through-build-config
Merge into: lp://qastaging/linaro-android-build-tools
Diff against target: 82 lines (+28/-14)
1 file modified
build-scripts/post-build-lava.py (+28/-14)
To merge this branch: bzr merge lp://qastaging/~asac/linaro-android-build-tools/select-lava-device-through-build-config
Reviewer Review Type Date Requested Status
Paul Sokolovsky Approve
Review via email: mp+105905@code.qastaging.launchpad.net

Description of the change

add support for selecting device type and even a concrete device in android build jobs.

 -> the latter is particularly interesting for running multiple benchmarks and repetitionms on the same machine!

Note: this code was not run... just developed dry. Please try out and fix potential syntax etc. and ping me when you are unhappy as I might not see the email :)...

To post a comment you must log in.
Revision history for this message
Andy Doan (doanac) wrote :

might want to update:

 https://wiki.linaro.org/Platform/Android/AndroidBuild-LavaIntegration

once the code is merged

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

+ config_json["device"] = test_device

This needs to be config_json["target"] (yay consistency)

Revision history for this message
Alexander Sack (asac) wrote :

repushed with michaels fix

lp://qastaging/~asac/linaro-android-build-tools/select-lava-device-through-build-config updated
465. By Alexander Sack

add support to pass LAVA_DEVICE_TYPE and LAVA_DEVICE through build config

Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

My understanding that now LAVA allows to specify specific board ID to run test on (like panda-2, meaning board #2 in panda cluster).

Then comment to LAVA that indeed, could be more consistency for "device_type" and "target" keys...

The code logic appears to ok otherwise, though I'd rewrite it a bit to be more clear (will do myself later I guess).

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches