Merge lp://qastaging/~asac/phablet-tools/wait-for-online-with-nm-tool into lp://qastaging/phablet-tools
Proposed by
Alexander Sack
| Status: | Superseded |
|---|---|
| Proposed branch: | lp://qastaging/~asac/phablet-tools/wait-for-online-with-nm-tool |
| Merge into: | lp://qastaging/phablet-tools |
| Prerequisite: | lp://qastaging/~asac/phablet-tools/improve-network-bringup-console-output |
| Diff against target: |
55 lines (+20/-25) 1 file modified
phablet-network-setup (+20/-25) |
| To merge this branch: | bzr merge lp://qastaging/~asac/phablet-tools/wait-for-online-with-nm-tool |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot | continuous-integration | Needs Fixing | |
| Ubuntu Phablet Team | Pending | ||
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2013-07-15.
Description of the change
based on lp:~asac/phablet-tools/improve-network-bringup-console-output this code moves to nm-tool for deciding whether a device is online or not...
This time I tested the code for the positive state (dev is online) and negative (stop network-manager).
I don't like the sh -c "..." way of doing this, but couldn't get the | easily wrapped in a variable without doing it that way :)...
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Unmerged revisions
- 131. By Alexander Sack
-
simplify device bringup "wait for online state" code; use nm-tool in phablet-
network- setup - 130. By Alexander Sack
-
improve debugging output of network device and IP bringup code in phablet-
network- setup
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
FAILED: Continuous integration, rev:131
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https:/
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://