Merge lp://qastaging/~attente/indicator-appmenu/indicator-appmenu into lp://qastaging/indicator-appmenu/13.10

Proposed by William Hua
Status: Merged
Approved by: Lars Karlitski
Approved revision: 239
Merged at revision: 238
Proposed branch: lp://qastaging/~attente/indicator-appmenu/indicator-appmenu
Merge into: lp://qastaging/indicator-appmenu/13.10
Diff against target: 141 lines (+65/-2)
2 files modified
src/window-menu-model.c (+18/-2)
tests/autopilot/tests/test_gedit.py (+47/-0)
To merge this branch: bzr merge lp://qastaging/~attente/indicator-appmenu/indicator-appmenu
Reviewer Review Type Date Requested Status
Lars Karlitski (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+162443@code.qastaging.launchpad.net

Commit message

Adds 'unity' action group.

This is needed because applications in general may already be using the 'application' and 'window' action groups for their own purposes, and unity-gtk-module should try to avoid using these if they're already being used.

Description of the change

Adds 'unity' action group.

This is needed because applications in general may already be using the 'application' and 'window' action groups for their own purposes, and unity-gtk-module should try to avoid using these if they're already being used.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ted Gould (ted) wrote :

Seems like this should probably be migrated to GActionMuxer with the
various actions at this point. Now that we've got three.

Revision history for this message
Lars Karlitski (larsu) wrote :

Ted: indicator-appmenu lets gtk handle action activation via gtk_widget_insert_action_group() (which uses an action muxer internally, of course ;) ).

The patch looks good to me, thanks Will!

review: Approve
Revision history for this message
Ted Gould (ted) wrote :

On Sat, 2013-05-04 at 16:01 +0000, Lars Uebernickel wrote:

> Ted: indicator-appmenu lets gtk handle action activation via gtk_widget_insert_action_group() (which uses an action muxer internally, of course ;) ).

I guess I was more concerned with us tracking the 3 action groups in the
struct. Can we use one action muxer and just pass it to the GTK
widgets?

Revision history for this message
Lars Karlitski (larsu) wrote :

> On Sat, 2013-05-04 at 16:01 +0000, Lars Uebernickel wrote:
>
> > Ted: indicator-appmenu lets gtk handle action activation via
> gtk_widget_insert_action_group() (which uses an action muxer internally, of
> course ;) ).
>
>
> I guess I was more concerned with us tracking the 3 action groups in the
> struct. Can we use one action muxer and just pass it to the GTK
> widgets?

No, but we don't really need to track the structs. We could just fetch them, set them on the widget, and unref them immediately.

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Is this good to merge now? Lars, can you please top-approve if it's the case?

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches