Mir

Merge lp://qastaging/~attente/mir/include-surface-placement into lp://qastaging/mir

  1. include-surface-placement
  2. Merge into development-branch
Proposed by William Hua
Status: Rejected
Rejected by: Alan Griffiths
Proposed branch: lp://qastaging/~attente/mir/include-surface-placement
Merge into: lp://qastaging/mir
Diff against target: 11 lines (+1/-0)
1 file modified
include/client/mir_toolkit/events/event.h (+1/-0)
To merge this branch: bzr merge lp://qastaging/~attente/mir/include-surface-placement
Reviewer Review Type Date Requested Status
Alan Griffiths Abstain
Daniel van Vugt Needs Fixing
Mir CI Bot continuous-integration Needs Fixing
Review via email: mp+318645@code.qastaging.launchpad.net

Commit message

Include window placement event header

Description of the change

Include window placement event header

To post a comment you must log in.
Revision history for this message
Daniel van Vugt (vanvugt) :
review: Approve
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
https://mir-jenkins.ubuntu.com/job/mir-autolanding/1158/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-mir/4138/console
    None: https://mir-jenkins.ubuntu.com/job/generic-land-mp/1221/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/4225
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/4215
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/4215
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/4215
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/4165/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/4165/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/4165/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/4165/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/4165/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/4165/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

And window_placement.h needs fixing too :)

0.26.0+zesty4215bzr4061/include/client/mir_toolkit/events/window_placement.h:39:1: error: unknown type name 'MirRectangle'

review: Needs Fixing
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

The mir_toolkit/events/*.h headers are a pointless mess. I don't think this makes things better or worse. (See also bug 1621828.)

review: Abstain
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

This is broken and, it seems, no-one cares enough to fix it.

Unmerged revisions

4061. By William Hua

Include window placement event header

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches