ubuntu-system-settings

Merge lp://qastaging/~attente/ubuntu-system-settings/1392699 into lp://qastaging/ubuntu-system-settings

  1. 1392699
  2. Merge into trunk
Proposed by William Hua
Status: Needs review
Proposed branch: lp://qastaging/~attente/ubuntu-system-settings/1392699
Merge into: lp://qastaging/ubuntu-system-settings
Diff against target: 269 lines (+102/-16)
4 files modified
plugins/language/DisplayLanguage.qml (+14/-6)
plugins/language/PageComponent.qml (+40/-4)
plugins/language/language-plugin.cpp (+37/-6)
plugins/language/language-plugin.h (+11/-0)
To merge this branch: bzr merge lp://qastaging/~attente/ubuntu-system-settings/1392699
Reviewer Review Type Date Requested Status
Ken VanDine Needs Information
PS Jenkins bot continuous-integration Pending
Review via email: mp+296271@code.qastaging.launchpad.net

Commit message

Make language and formats locale independent settings

Description of the change

Make language and formats locale independent settings

To post a comment you must log in.
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Looks good and seems to work fine.

Please update the test plan to match https://wiki.ubuntu.com/Process/Merges/TestPlan/ubuntu-system-settings#Language_.26_Text

review: Approve
Reply
Revision history for this message
Ken VanDine (ken-vandine) wrote :

We need Pat and design to agree to what we're implementing here and from the conversation on IRC I have the feeling not everyone is agreement to land this.

review: Needs Information
Reply

Unmerged revisions

1662. By William Hua

Only change the language if the mode is 0

1661. By William Hua

Make language and formats locale independent settings

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches