Unity Settings Daemon

Merge lp://qastaging/~attente/unity-settings-daemon/1226962 into lp://qastaging/unity-settings-daemon

  1. 1226962
  2. Merge into trunk
Proposed by William Hua
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 4123
Merged at revision: 4125
Proposed branch: lp://qastaging/~attente/unity-settings-daemon/1226962
Merge into: lp://qastaging/unity-settings-daemon
Diff against target: 323 lines (+139/-23)
2 files modified
debian/changelog (+9/-0)
plugins/keyboard/gsd-keyboard-manager.c (+130/-23)
To merge this branch: bzr merge lp://qastaging/~attente/unity-settings-daemon/1226962
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Review via email: mp+280783@code.qastaging.launchpad.net

Commit message

* plugins/keyboard/gsd-keyboard-manager.c:
  - Fix shortcuts for non-latin keyboard layouts in certain programs,
    but only when the user's layout switching shortcuts are not
    Shift_L, Shift_R, <Shift>Shift_L, or <Shift>Shift_R (LP: #1226962)

Description of the change

I'm currently maintaining a PPA (https://launchpad.net/~attente/+archive/ubuntu/java-non-latin-shortcuts) for this long-standing annoying bug. The PPA works for probably 99% of cases, however, it could not be merged because it causes a severe regression when the user chooses Shift_L, Shift_R, <Shift>Shift_L, or <Shift>Shift_R as a layout-switching shortcut: the user is unable to type uppercase text. This change contains the behaviour of that PPA, but monitors the switching shortcut to decide whether to do it or not.

To post a comment you must log in.
Revision history for this message
William Hua (attente) wrote :

Simple test case:

- add Greek keyboard layout in unity-control-center Text Entry panel
- launch Inkscape
- switch to Greek using the keyboard indicator
- try some shortcuts
  - Ctrl+Shift+D (normally opens the Document Preferences dialog)
  - Ctrl+Shift+F (normally opens the Fill and Stroke panel)
  - Ctrl+Shift+A (normally opens the Align and Distribute panel)

The shortcuts don't work with the current version of unity-settings-daemon, this patch should fix it.

Revision history for this message
Sebastien Bacher (seb128) wrote :

I'm not going to claim to understand the details of thosse keyboard layout and hotkeys but the approach and code look fine to me

review: Approve
Revision history for this message
Iain Lane (laney) wrote :

It broke shortcuts in terminator for me, so I reverted this for now - sorry.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches