Merge lp://qastaging/~axlrose112/midori/midori-restful_client-feature into lp://qastaging/midori
Proposed by
axlrose112
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~axlrose112/midori/midori-restful_client-feature |
| Merge into: | lp://qastaging/midori |
| Diff against target: |
1016 lines (+1012/-0) 1 file modified
extensions/restful-client.vala (+1012/-0) |
| To merge this branch: | bzr merge lp://qastaging/~axlrose112/midori/midori-restful_client-feature |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Cris Dywan | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
midori extension resful-client
To post a comment you must log in.
Revision history for this message
| axlrose112 (axlrose112) wrote | # |
Unmerged revisions
- 7046. By axlrose112
-
midori restful client feature
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
As an observation the coding style diverts a bit and uses Java style VariableNames rather than variableNames, though as always I consider this up to the extension author(s). The code is generally very clean and modular, which is nice.
Suggestions for improvement:
You could use Midori.Database API to simplify error handling and binding of parameters. Compiled statements are more efficient than concatenating queries on demand.
c.f. grep Midori.Database extensions
I didn't figure out how to create projects. I think the UX needs improvement.
A "Submit" button would seem like a nice idea, through trial and error I found out that hitting Enter in the text field makes a request, but it took me a moment.
^^ I think the projects UX is critical here for landing a first version, the other ones are optional.