Compiz Core

Merge lp://qastaging/~azzar1/compiz-core/fix-919139 into lp://qastaging/compiz-core

fix-919139
Merge into 0.9.7

Proposed by Andrea Azzarone on 2012-03-30

Status:	Merged
Merged at revision:	3083
Proposed branch:	lp://qastaging/~azzar1/compiz-core/fix-919139
Merge into:	lp://qastaging/compiz-core
Diff against target:	87 lines (+9/-51) 2 files modified plugins/scale/CMakeLists.txt (+1/-1) plugins/scale/src/scale.cpp (+8/-50)
To merge this branch:	bzr merge lp://qastaging/~azzar1/compiz-core/fix-919139
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Daniel van Vugt		2012-03-30	Approve on 2012-04-01
Review via email: mp+100156@code.qastaging.launchpad.net

Commit message

Change the behavior of the option "On all output devices."

Description of the change

== The problem ==
In multi-monitor environment, windows should spread on the monitor in which they reside.

== The fix ==
Change the behavior of the option "On all output devices."

== Test ==
Not yet implemented. I'd love to write unit-tests but I need to use CompWindow and I can't find an easy way to create a fake CompWindow (CompWindow has a private ctor) or to mock it.

lp://qastaging/~azzar1/compiz-core/fix-919139 updated on 2012-03-30

3081. By Andrea Azzarone on 2012-03-30: Fix coding style.
3082. By Andrea Azzarone on 2012-03-30: Don't use c++0x.

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2012-04-01:

/home/dan/bzr/compiz-core/spread/plugins/scale/src/scale.cpp: In member function ‘SlotArea::vector PrivateScaleScreen::getSlotAreas()’:
/home/dan/bzr/compiz-core/spread/plugins/scale/src/scale.cpp:491:39: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]