Release Upgrader

Merge lp://qastaging/~azzar1/ubuntu-release-upgrader/fix-1799310 into lp://qastaging/ubuntu-release-upgrader

  1. fix-1799310
  2. Merge into trunk
Proposed by Andrea Azzarone
Status: Merged
Merged at revision: 3212
Proposed branch: lp://qastaging/~azzar1/ubuntu-release-upgrader/fix-1799310
Merge into: lp://qastaging/ubuntu-release-upgrader
Diff against target: 199 lines (+93/-1)
8 files modified
DistUpgrade/DistUpgradeController.py (+21/-0)
DistUpgrade/DistUpgradeView.py (+3/-0)
DistUpgrade/DistUpgradeViewGtk3.py (+24/-0)
DistUpgrade/DistUpgradeViewKDE.py (+20/-0)
DistUpgrade/DistUpgradeViewNonInteractive.py (+2/-0)
DistUpgrade/DistUpgradeViewText.py (+6/-1)
debian/changelog (+16/-0)
debian/control (+1/-0)
To merge this branch: bzr merge lp://qastaging/~azzar1/ubuntu-release-upgrader/fix-1799310
Reviewer Review Type Date Requested Status
Sebastien Bacher Needs Information
Review via email: mp+361896@code.qastaging.launchpad.net

Commit message

Ask for confirmation if Livepatch is turned on, and you are upgrading to a version where Livepatch is not available.

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks for your work, one question. The design image on https://wiki.ubuntu.com/ReleaseUpgrades has a settings button on the bottom left corner, is that omitted on purpose in the implementation? (if so maybe add a comment stating why?)

review: Needs Information
Revision history for this message
Andrea Azzarone (azzar1) wrote :

> Thanks for your work, one question. The design image on
> https://wiki.ubuntu.com/ReleaseUpgrades has a settings button on the bottom
> left corner, is that omitted on purpose in the implementation? (if so maybe
> add a comment stating why?)

The main reasons are:
- atm there is no way to ask software-properties-gtk to open the livepatch tab. We can open tab by numbers and not by name. Considering that we're moving around tabs, using the number is not a good solution.
- I want to keep the diff as small as possible. In particualar I had to add a mechanism to show that button only under Gtk3. Considering the controller/view model of ubuntu-release-upgrader it's not naive as it seems.

Considering these mpt agreed to not show the button for the moment.

Revision history for this message
Sebastien Bacher (seb128) wrote :

(thanks for the reply, also I was just having a look but would prefer if someone from foundations could review/upload so don't bail out just because I commented ;-)

Revision history for this message
Brian Murray (brian-murray) wrote :

I'll test this out today.

Revision history for this message
Brian Murray (brian-murray) wrote :

It's not a blocker for me per se but I thought it worth mentioning that some things don't match what is in the design. The dialog does not morph and the "turn off" dialog does not have the title bar label indicated in the design. Let me know if you want to get this changed or not. If you don't I'll merge it and upload it to the devel release.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches