Unity

Merge lp://qastaging/~azzar1/unity/dash-fonts into lp://qastaging/unity

  1. dash-fonts
  2. Merge into trunk
Proposed by Andrea Azzarone
Status: Merged
Approved by: Andrea Azzarone
Approved revision: no longer in the source branch.
Merged at revision: 2105
Proposed branch: lp://qastaging/~azzar1/unity/dash-fonts
Merge into: lp://qastaging/unity
Prerequisite: lp://qastaging/~azzar1/unity/fix-748101
Diff against target: 1066 lines (+569/-89)
15 files modified
plugins/unityshell/resources/search_circle.svg (+146/-0)
plugins/unityshell/resources/search_close.svg (+134/-0)
plugins/unityshell/resources/search_spin.svg (+174/-0)
plugins/unityshell/src/DashStyle.cpp (+17/-8)
plugins/unityshell/src/DashStyle.h (+1/-0)
plugins/unityshell/src/FilterExpanderLabel.cpp (+8/-8)
plugins/unityshell/src/FilterExpanderLabel.h (+2/-2)
plugins/unityshell/src/FilterMultiRangeButton.cpp (+1/-3)
plugins/unityshell/src/PlacesGroup.cpp (+15/-13)
plugins/unityshell/src/PlacesGroup.h (+1/-0)
plugins/unityshell/src/ResultRendererTile.cpp (+4/-1)
plugins/unityshell/src/SearchBar.cpp (+48/-31)
plugins/unityshell/src/SearchBarSpinner.cpp (+8/-18)
plugins/unityshell/src/SearchBarSpinner.h (+1/-2)
plugins/unityshell/src/StaticCairoText.cpp (+9/-3)
To merge this branch: bzr merge lp://qastaging/~azzar1/unity/dash-fonts
Reviewer Review Type Date Requested Status
John Lea (community) design Approve
Andrea Cimitan (community) design Approve
Mirco Müller (community) Approve
Review via email: mp+95989@code.qastaging.launchpad.net

Description of the change

The problems
-------------
Bug #927710: No text inside multirange filters
Bug #942508: Dash - Font metrics and colors are wrong

The fix
-------
Update the dash fonts.

Test
----
Not applicable.

http://ubuntuone.com/1a4mdRPJ8tgFrg4bMuNiQE

I've merged lp:~sladen/unity/unity-drunken-spinner-lp943656.

To post a comment you must log in.
Revision history for this message
John Lea (johnlea) wrote :

Where can I see (the testing computer?)

On 05/03/12 20:12, Andrea Azzarone wrote:
> You have been requested to review the proposed merge of lp:~andyrock/unity/dash-fonts into lp:unity.
>
> For more details, see:
> https://code.launchpad.net/~andyrock/unity/dash-fonts/+merge/95989
>
> The problems
> -------------
> Bug #927710: No text inside multirange filters
> Bug #942508: Dash - Font metrics and colors are wrong
>
> The fix
> -------
> Update the dash fonts.
>
> Test
> ----
> Not applicable.
>
>

--
John Lea | Ubuntu Desktop User Experience Lead
Canonical www.canonical.com | Ubuntu www.ubuntu.com
27th Floor, 21-24 Millbank Tower, London, SW1P 4QP
Tel: +44 (0) 20 7630 2415 | Email: <email address hidden>

Revision history for this message
Mirco Müller (macslow) wrote :

> Where can I see (the testing computer?)

http://people.canonical.com/~mmueller/after-927710.png

Revision history for this message
Mirco Müller (macslow) wrote :

Looking good sofar. But we need to expose those colors and font-attributes in DashStyle in the long run. Otherwise we'll never get this tweaking off our shoulders.

review: Approve
Revision history for this message
Andrea Cimitan (cimi) wrote :

Looking at mirco's screenshot, the text in the search box is not aligned with the category headers.

Revision history for this message
John Lea (johnlea) wrote :

Well spotted, let's solve this last issue before landing this fix.

Revision history for this message
Andrea Azzarone (azzar1) wrote :

> Looking at mirco's screenshot, the text in the search box is not aligned with
> the category headers.

I need new assets for the search bar icons (64x64 is too big!). I've tried to resize them by myself but I had some problems.

> Looking good sofar. But we need to expose those colors and font-attributes in DashStyle in the long run. Otherwise
> we'll never get this tweaking off our shoulders.

Indeed.

Revision history for this message
Andrea Azzarone (azzar1) wrote :

> Well spotted, let's solve this last issue before landing this fix.

Fixed.

Revision history for this message
Andrea Cimitan (cimi) wrote :

With the latest fix, from the screenshot the visuals are ok

review: Approve (design)
Revision history for this message
Unity Merger (unity-merger) wrote :

No proposals found for merge of lp:~andyrock/unity/fix-748101 into lp:unity.

Revision history for this message
Mirco Müller (macslow) wrote :

Updated screenshot after Andy's latest fix-update: http://people.canonical.com/~mmueller/after-927710-2.png

Revision history for this message
Mirco Müller (macslow) wrote :

Can we sign this off as approved now John?

Revision history for this message
Andrea Azzarone (azzar1) wrote :

> Updated screenshot after Andy's latest fix-update:
> http://people.canonical.com/~mmueller/after-927710-2.png

Can you build this branch from scratch? This screenshot still has the alignment issue.
On my system: http://ubuntuone.com/1a4mdRPJ8tgFrg4bMuNiQE

Revision history for this message
Andrea Cimitan (cimi) wrote :

Which is the real screenshot? I only approve the one from andrea.

Revision history for this message
John Lea (johnlea) :
review: Approve (design)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.