Merge lp://qastaging/~azzar1/unity/fix-1049601 into lp://qastaging/unity
Proposed by
Andrea Azzarone
| Status: | Merged |
|---|---|
| Approved by: | Andrea Azzarone |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 2876 |
| Proposed branch: | lp://qastaging/~azzar1/unity/fix-1049601 |
| Merge into: | lp://qastaging/unity |
| Diff against target: |
129 lines (+31/-15) 3 files modified
launcher/Launcher.cpp (+4/-0) unity-shared/IconRenderer.cpp (+25/-14) unity-shared/IconRenderer.h (+2/-1) |
| To merge this branch: | bzr merge lp://qastaging/~azzar1/unity/fix-1049601 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
| John Lea (community) | design | Approve | |
| Marco Trevisan (Treviño) | Approve | ||
|
Review via email:
|
|||
Commit message
Update shortcut overlay visual design.
Description of the change
== Problem ==
Launcher - The shortcut overlays that are displayed on top of Launcher icons when the SUPER key is held down need to use the correct assets, and be tinted with the average background colour.
== Test ==
Not applicable: visual change.
Screenshot: https:/
To post a comment you must log in.
Revision history for this message
| John Lea (johnlea) | # |
review:
Approve
(design)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Check if you can use a map of smart pointers for the textures without being too invasive, also it would be nice if you'd use an auto const& in the foreach... Anyway overall this is already fine for me.