Merge lp://qastaging/~azzar1/unity/fix-750311 into lp://qastaging/unity
Proposed by
Andrea Azzarone
| Status: | Merged |
|---|---|
| Merged at revision: | 1330 |
| Proposed branch: | lp://qastaging/~azzar1/unity/fix-750311 |
| Merge into: | lp://qastaging/unity |
| Diff against target: |
159 lines (+43/-2) 7 files modified
plugins/unityshell/src/AbstractLauncherIcon.h (+1/-0) plugins/unityshell/src/Launcher.cpp (+30/-0) plugins/unityshell/src/Launcher.h (+3/-0) plugins/unityshell/src/LauncherHideMachine.cpp (+3/-2) plugins/unityshell/src/LauncherHideMachine.h (+1/-0) plugins/unityshell/src/LauncherIcon.cpp (+3/-0) plugins/unityshell/src/TrashLauncherIcon.cpp (+2/-0) |
| To merge this branch: | bzr merge lp://qastaging/~azzar1/unity/fix-750311 |
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jason Smith (community) | Approve | ||
| Marco Trevisan (Treviño) | Approve | ||
|
Review via email:
|
|||
Description of the change
Adds a pulse animation when something is dropped into the launcher trash icon. Since dnd from `third` applications (such as desktop, nautilus, etc.) is broken at the moment, you should test only launcher icon dnd.
I have added a new Hide Machine State. In this way the Launcher should only disappear after the pulse has finished. If another cleaner solution exists, please let me know.
To post a comment you must log in.
Revision history for this message
| Marco Trevisan (Treviño) (3v1n0) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
+1