Merge lp://qastaging/~azzar1/unity/fix-764905 into lp://qastaging/unity
Proposed by
Andrea Azzarone
| Status: | Merged |
|---|---|
| Approved by: | Mirco Müller |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 1276 |
| Proposed branch: | lp://qastaging/~azzar1/unity/fix-764905 |
| Merge into: | lp://qastaging/unity |
| Diff against target: |
177 lines (+56/-12) 5 files modified
CMakeLists.txt (+1/-1) plugins/unityshell/src/DeviceLauncherIcon.cpp (+24/-3) plugins/unityshell/src/DeviceLauncherIcon.h (+2/-1) plugins/unityshell/src/LauncherController.cpp (+24/-7) plugins/unityshell/src/unityshell.cpp (+5/-0) |
| To merge this branch: | bzr merge lp://qastaging/~azzar1/unity/fix-764905 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Mirco Müller (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Ejects a usb pen drive using the drag and drop to the trash. Shows a osd notification too.
To post a comment you must log in.
Revision history for this message
| Mirco Müller (macslow) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The strings used for the notification need to be translated. Using these hard-coded strings makes this impossible. Please fix it by using the typical _("") macro.