Merge lp://qastaging/~azzar1/unity/fix-797808 into lp://qastaging/unity

Will this work with rotated displays?

Example: I have my display (resolution: 1280x1024) connected in my notebook. If it's rotated, the working area will be 1024x1280. It's bigger, in area, than 1024x600, but the new condition will not be true (because the width is the same) and the automaximize will still enabled.

Maybe we should use area in this case? Something like:

if (screen_width * screen_height > THRESHOLD_WIDTH * THRESHOLD_HEIGHT)
{
    return false;
}

And a minor thing: It's easier to access the bug report if the complete URL is put in comment (and not only the bug number). What do you think?

> Will this work with rotated displays?
>
> Example: I have my display (resolution: 1280x1024) connected in my notebook.
> If it's rotated, the working area will be 1024x1280. It's bigger, in area,
> than 1024x600, but the new condition will not be true (because the width is
> the same) and the automaximize will still enabled.
>
> Maybe we should use area in this case? Something like:
>
> if (screen_width * screen_height > THRESHOLD_WIDTH * THRESHOLD_HEIGHT)
> {
> return false;
> }
>

Makes sense. Done.

> And a minor thing: It's easier to access the bug report if the complete URL is
> put in comment (and not only the bug number). What do you think?

Done.

Looks good!

Code looks good and works ok. But please add a manual-test describing how to test this (lowering the resolution below the 1024x600 threshold with the system-settings for the display). Also the note about the automaximize-threshold set to 20 in ccsm (experimental-tab of unity-plugin) should be added. Otherwise the tester might be confused and assuming this fix doesn't work.

Done.

+1

looking good now