Merge lp://qastaging/~azzar1/unity/fix-830801 into lp://qastaging/unity
Proposed by
Andrea Azzarone
| Status: | Merged |
|---|---|
| Approved by: | Andrea Azzarone |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 2298 |
| Proposed branch: | lp://qastaging/~azzar1/unity/fix-830801 |
| Merge into: | lp://qastaging/unity |
| Diff against target: |
44 lines (+21/-3) 2 files modified
manual-tests/Switcher.txt (+18/-0) plugins/unityshell/src/StaticCairoText.cpp (+3/-3) |
| To merge this branch: | bzr merge lp://qastaging/~azzar1/unity/fix-830801 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Tim Penhey (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Fix the switcher so it displays the full title of apps in Chinese
Description of the change
== Problem ==
App Switcher (Alt+Tab) doesn't display the full title of apps in Chinese
== Fix ==
Use std::ceil to avoid this problem.
== Test ==
StaticCairoText needs a huge refactor to support unit-tests. I can add a unit-test without slowing down the code using an #ifdef TESTS_ENABLED but I don't like it too much.
To post a comment you must log in.
Revision history for this message
| Sam Spilsbury (smspillaz) wrote | # |
Revision history for this message
| Andrea Azzarone (azzar1) wrote | # |
Revision history for this message
| Tim Penhey (thumper) | # |
review:
Approve
Revision history for this message
| Unity Merger (unity-merger) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
> StaticCairoText needs a huge refactor to support unit-tests. I can add a unit-test without slowing down the code using > an #ifdef TESTS_ENABLED but I don't like it too much.
I don't think "huge refactor" is right here.
Probably makes more sense to split StaticCairoText into an mvc type thing, and make the view an interface so that you can mock it out in the tests.
The only other thing I can think of is the requirement for GdkScreen * to get font settings since it reads them from x propeties, but I am pretty sure this can be mocked out.
Not going to block it on this though.