Merge lp://qastaging/~azzar1/unity/fix-925021 into lp://qastaging/unity
Proposed by
Andrea Azzarone
| Status: | Merged |
|---|---|
| Approved by: | Marco Trevisan (Treviño) |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 2197 |
| Proposed branch: | lp://qastaging/~azzar1/unity/fix-925021 |
| Merge into: | lp://qastaging/unity |
| Prerequisite: | lp://qastaging/~3v1n0/unity/monitor-aware-launcher-icons |
| Diff against target: |
52 lines (+6/-6) 3 files modified
plugins/unityshell/src/Launcher.cpp (+1/-1) plugins/unityshell/src/SpacerLauncherIcon.cpp (+2/-2) plugins/unityshell/src/SpacerLauncherIcon.h (+3/-3) |
| To merge this branch: | bzr merge lp://qastaging/~azzar1/unity/fix-925021 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Marco Trevisan (Treviño) | Approve | ||
|
Review via email:
|
|||
Commit message
Inserting items into launcher makes unnecessary animations on other monitors
Description of the change
== Problem ==
Inserting items into launcher makes unnecessary animations on other monitors
== Fix ==
Derive SpacerLauncherIcon from SingleMonitorLa
== Test ==
SingleMonitorLa
To post a comment you must log in.
Revision history for this message
| Marco Trevisan (Treviño) (3v1n0) wrote | # |
Revision history for this message
| Andrea Azzarone (azzar1) wrote | # |
Revision history for this message
| Marco Trevisan (Treviño) (3v1n0) wrote | # |
Revision history for this message
| Andrea Azzarone (azzar1) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This is fine and works, one thing that should improved is this case:
1) Grab a launcher icon on monitor 1
2) Drag it to the launcher on monitor 2
In that case, the SpacerLauncherIcon on monitor 1 should be removed, while a new one on monitor 2 should be added. Am I wrong?