Unity

Merge lp://qastaging/~azzar1/unity/fix-971345 into lp://qastaging/unity

  1. fix-971345
  2. Merge into trunk
Proposed by Andrea Azzarone
Status: Merged
Approved by: Tim Penhey
Approved revision: no longer in the source branch.
Merged at revision: 2213
Proposed branch: lp://qastaging/~azzar1/unity/fix-971345
Merge into: lp://qastaging/unity
Diff against target: 105 lines (+14/-18)
2 files modified
plugins/unityshell/src/DeviceLauncherIcon.cpp (+12/-17)
plugins/unityshell/src/DeviceLauncherIcon.h (+2/-1)
To merge this branch: bzr merge lp://qastaging/~azzar1/unity/fix-971345
Reviewer Review Type Date Requested Status
Tim Penhey (community) Approve
Review via email: mp+100606@code.qastaging.launchpad.net

Commit message

Fix a crash in unity::launcher::DeviceLauncherIcon::ShowNotification.

Description of the change

== Problem ==
We have a crash in unity::launcher::DeviceLauncherIcon::ShowNotification.

== The fix ==
Store the return value of g_volume_get_name(volume_) in a member variable.

== Test ==
We already have manual tests for the device launcher icons.

To post a comment you must log in.
Revision history for this message
Tim Penhey (thumper) wrote :

Looks fine.

review: Approve
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Fix look good to me, but why adding another member parameter when you can just re-use tooltip_text?

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.