Merge lp://qastaging/~azzar1/unity/fix-973386 into lp://qastaging/unity

Proposed by Andrea Azzarone
Status: Merged
Approved by: Tim Penhey
Approved revision: no longer in the source branch.
Merged at revision: 2270
Proposed branch: lp://qastaging/~azzar1/unity/fix-973386
Merge into: lp://qastaging/unity
Diff against target: 287 lines (+85/-47)
7 files modified
manual-tests/ShortcutsOverlay.txt (+14/-0)
plugins/unityshell/src/ShortcutController.cpp (+28/-12)
plugins/unityshell/src/ShortcutController.h (+3/-2)
plugins/unityshell/src/ShortcutView.cpp (+30/-0)
plugins/unityshell/src/ShortcutView.h (+5/-0)
plugins/unityshell/src/unityshell.cpp (+5/-22)
tests/autopilot/autopilot/tests/test_shortcut_hint.py (+0/-11)
To merge this branch: bzr merge lp://qastaging/~azzar1/unity/fix-973386
Reviewer Review Type Date Requested Status
Tim Penhey (community) Approve
Review via email: mp+101451@code.qastaging.launchpad.net

Commit message

The keyboard shortcuts overlay bottom is truncated.

Description of the change

== Problem ==
The keyboard shortcuts overlay bottom is truncated. I think that this regression is due to Ubuntu fonts updates.

== Fix ==
Make the size of the shortcut overlay more dynamic.

== Test ==
Manual test added. Removed an obsolete AP test too.

This branch is partially inspired by https://code.launchpad.net/~3v1n0/unity/unity-dialog. Kudos to Marco Trevisan :)

UNBLOCK

To post a comment you must log in.
Revision history for this message
Tim Penhey (thumper) wrote :

Appears to work.

review: Approve
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Cool.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.