Unity

Merge lp://qastaging/~azzar1/unity/fix-977961 into lp://qastaging/unity

fix-977961
Merge into trunk

Proposed by Andrea Azzarone on 2012-04-10

Status:

Merged

Approved by:

Gord Allott on 2012-04-11

Approved revision:

no longer in the source branch.

Merged at revision:

2271

Proposed branch:

lp://qastaging/~azzar1/unity/fix-977961

Merge into:

lp://qastaging/unity

Diff against target:

286 lines (+78/-49)

6 files modified

plugins/unityshell/src/LensBar.cpp (+2/-42)
plugins/unityshell/src/LensBar.h (+0/-2)
plugins/unityshell/src/LensBarIcon.cpp (+40/-5)
plugins/unityshell/src/LensBarIcon.h (+7/-0)
tests/autopilot/autopilot/emulators/unity/dash.py (+9/-0)
tests/autopilot/autopilot/tests/test_dash.py (+20/-0)

To merge this branch:

bzr merge lp://qastaging/~azzar1/unity/fix-977961

Medium

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Alex Launi (community)	quality	2012-04-10	Needs Fixing on 2012-04-10
Review via email: mp+101397@code.qastaging.launchpad.net

Commit message

Lens selection should work when clicking in the rectangle outside of the icon.

Description of the change

UNBLOCK

== Problem ==
Lens selection should work when clicking in the rectangle outside of the icon.

== Fix ==
Now lens bar icons have the same size of the focus highlights.

== Test ==
AP test added.

Revision history for this message

Alex Launi (alexlauni) wrote on 2012-04-10:

Please rename the DashLensBar(DashTestCase) class to DashLensBarTests(DashTestCase):

review: Approve (quality)

Revision history for this message

Alex Launi (alexlauni) wrote on 2012-04-10:

Sorry I hit save too quick/by accident.

Please rename the DashLensBar(DashTestCase) class to DashLensBarTests(DashTestCase):
Move the dash ensure_visible() and the getting of the lensbar into a setUp method. Every other lensbar test will need to do the same thing. Keep tests as clean as possible.

review: Needs Fixing (quality)

Revision history for this message

Andrea Azzarone (azzar1) wrote on 2012-04-10:

Done.