Unity

Merge lp://qastaging/~azzar1/unity/fix-980924 into lp://qastaging/unity

  1. fix-980924
  2. Merge into trunk
Proposed by Andrea Azzarone
Status: Merged
Approved by: Andrea Azzarone
Approved revision: no longer in the source branch.
Merged at revision: 2303
Proposed branch: lp://qastaging/~azzar1/unity/fix-980924
Merge into: lp://qastaging/unity
Diff against target: 105 lines (+3/-26)
4 files modified
plugins/unityshell/src/LensBar.cpp (+2/-14)
plugins/unityshell/src/LensBarIcon.cpp (+1/-0)
plugins/unityshell/src/OverlayRenderer.cpp (+0/-9)
plugins/unityshell/src/UBusMessages.h (+0/-3)
To merge this branch: bzr merge lp://qastaging/~azzar1/unity/fix-980924
Reviewer Review Type Date Requested Status
Gord Allott (community) Approve
Marco Trevisan (Treviño) Approve
Review via email: mp+102200@code.qastaging.launchpad.net

Commit message

Fixes bug #980924.

Description of the change

== Problem ==
[regression] Dash keeps repainting unnecessarily

== Fix ==
Partially revert r2248 [1] without reintroducing the bottom-right bug.

[1] https://code.launchpad.net/~unity-team/unity/unity.fix-bottom-right-dash-decoration-corner

To post a comment you must log in.
Revision history for this message
Gord Allott (gordallott) wrote :

UBUS_DASH_DECORATION_DAMAGED isn't used anymore with this right? we should remove the UBUS message define and the signal connect in OverlayRenderer too

review: Needs Fixing
Revision history for this message
Andrea Azzarone (azzar1) wrote :

> UBUS_DASH_DECORATION_DAMAGED isn't used anymore with this right? we should
> remove the UBUS message define and the signal connect in OverlayRenderer too

Done.

Revision history for this message
Andrea Cimitan (cimi) wrote :

Fine for me now, waiting supergord.

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

LGTM

review: Approve
Revision history for this message
Gord Allott (gordallott) :
review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/668/console reported an error when processing this lp:~andyrock/unity/fix-980924 branch.
Not merging it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.