Unity

Merge lp://qastaging/~azzar1/unity/fix-983989 into lp://qastaging/unity

  1. fix-983989
  2. Merge into trunk
Proposed by Andrea Azzarone
Status: Merged
Approved by: Andrea Azzarone
Approved revision: no longer in the source branch.
Merged at revision: 2301
Proposed branch: lp://qastaging/~azzar1/unity/fix-983989
Merge into: lp://qastaging/unity
Diff against target: 118 lines (+32/-1)
3 files modified
plugins/unityshell/src/LauncherController.h (+1/-0)
standalone-clients/CMakeLists.txt (+23/-0)
standalone-clients/TestLauncher.cpp (+8/-1)
To merge this branch: bzr merge lp://qastaging/~azzar1/unity/fix-983989
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
Sam Spilsbury (community) Approve
Review via email: mp+102411@code.qastaging.launchpad.net

Commit message

Fix compilation of standalone launcher.

Description of the change

== Problem ==
make launcher fails

== Fix ==
Fix CMakeList.txt for standalone launcher.

To post a comment you must log in.
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

We need to have a jenkins job for the all target, these build failures are silly.

review: Approve
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

There's no need to mention also the .h files in the CMakeLists.txt (if the .ccp file mention it), but since you're just following what has been done before, it's fine for now.

review: Approve
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

> We need to have a jenkins job for the all target, these build failures are
> silly.

what does it have to do with jenkins? We are not calling this target in the packaging AFAIK.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.