Unity

Merge lp://qastaging/~azzar1/unity/lp-1152733 into lp://qastaging/unity

  1. lp-1152733
  2. Merge into trunk
Proposed by Andrea Azzarone
Status: Merged
Approved by: Brandon Schaefer
Approved revision: no longer in the source branch.
Merged at revision: 3211
Proposed branch: lp://qastaging/~azzar1/unity/lp-1152733
Merge into: lp://qastaging/unity
Diff against target: 1365 lines (+570/-348)
17 files modified
UnityCore/FilesystemLenses.h (+4/-4)
UnityCore/HomeLens.cpp (+8/-3)
UnityCore/HomeLens.h (+5/-4)
UnityCore/Lenses.h (+3/-0)
dash/ApplicationStarter.h (+40/-0)
dash/ApplicationStarterImp.cpp (+72/-0)
dash/ApplicationStarterImp.h (+34/-0)
dash/CMakeLists.txt (+1/-0)
dash/DashController.cpp (+2/-1)
dash/DashView.cpp (+21/-66)
dash/DashView.h (+6/-3)
dash/ResultViewGrid.cpp (+2/-1)
dash/StandaloneDash.cpp (+3/-1)
tests/CMakeLists.txt (+1/-0)
tests/mock-lenses.h (+271/-0)
tests/test_dash_view.cpp (+67/-0)
tests/test_home_lens.cpp (+30/-265)
To merge this branch: bzr merge lp://qastaging/~azzar1/unity/lp-1152733
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Brandon Schaefer (community) Approve
Review via email: mp+153020@code.qastaging.launchpad.net

Commit message

Export the event timestamp on dash icon click.

Description of the change

== Problem ==
Nautilus windows don't get the the focus when opened via the dash.

== Fix ==
Export the event timestamp on dash icon click. Please keep in mind that the diff is not so small but I just moved code for the most.

== Test ==
Unit test added. Just tests ApplicationStarter*::Launch is getting called.

To post a comment you must log in.
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

Awesome, confirmed working here. Tests pass. LGTM

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
Unapproved changes made after approval.
http://jenkins.qa.ubuntu.com/job/unity-mbs-autolanding/486/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mbs-autolanding/./build=pbuilder,distribution=raring,flavor=amd64/486/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mbs-autolanding/./build=pbuilder,distribution=raring,flavor=i386/486/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

Approved!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.