Merge lp://qastaging/~azzar1/unity/megasuper-keynav into lp://qastaging/unity
Proposed by
Andrea Azzarone
| Status: | Merged |
|---|---|
| Approved by: | Andrea Azzarone |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 1998 |
| Proposed branch: | lp://qastaging/~azzar1/unity/megasuper-keynav |
| Merge into: | lp://qastaging/unity |
| Diff against target: |
1829 lines (+614/-261) 34 files modified
plugins/unityshell/src/DashView.cpp (+128/-14) plugins/unityshell/src/DashView.h (+3/-1) plugins/unityshell/src/FilterAllButton.h (+1/-0) plugins/unityshell/src/FilterBar.cpp (+25/-6) plugins/unityshell/src/FilterBar.h (+10/-2) plugins/unityshell/src/FilterBasicButton.cpp (+12/-0) plugins/unityshell/src/FilterBasicButton.h (+0/-2) plugins/unityshell/src/FilterExpanderLabel.cpp (+55/-16) plugins/unityshell/src/FilterExpanderLabel.h (+13/-3) plugins/unityshell/src/FilterFactory.cpp (+2/-2) plugins/unityshell/src/FilterFactory.h (+3/-1) plugins/unityshell/src/FilterGenreButton.h (+1/-1) plugins/unityshell/src/FilterMultiRangeButton.cpp (+2/-1) plugins/unityshell/src/FilterMultiRangeButton.h (+1/-2) plugins/unityshell/src/FilterMultiRangeWidget.cpp (+1/-1) plugins/unityshell/src/FilterRatingsButton.cpp (+99/-22) plugins/unityshell/src/FilterRatingsButton.h (+11/-0) plugins/unityshell/src/FilterWidget.cpp (+0/-39) plugins/unityshell/src/FilterWidget.h (+0/-48) plugins/unityshell/src/LensBar.cpp (+4/-11) plugins/unityshell/src/LensBar.h (+0/-1) plugins/unityshell/src/LensBarIcon.cpp (+1/-0) plugins/unityshell/src/LensView.cpp (+48/-5) plugins/unityshell/src/LensView.h (+7/-3) plugins/unityshell/src/PlacesGroup.cpp (+48/-39) plugins/unityshell/src/PlacesGroup.h (+2/-0) plugins/unityshell/src/PreviewBase.h (+0/-2) plugins/unityshell/src/PreviewBasicButton.h (+0/-1) plugins/unityshell/src/ResultViewGrid.cpp (+22/-13) plugins/unityshell/src/SearchBar.cpp (+34/-15) plugins/unityshell/src/SearchBar.h (+1/-0) standalone-clients/CMakeLists.txt (+0/-3) tests/autopilot/autopilot/emulators/unity/dash.py (+26/-0) tests/autopilot/autopilot/tests/test_dash.py (+54/-7) |
| To merge this branch: | bzr merge lp://qastaging/~azzar1/unity/megasuper-keynav |
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| John Lea (community) | design | Approve | |
| Tim Penhey (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Depends on https:/
Implements dash key navigation.
known issues:
- shift + tab doesn't work well because of this: bug 931393
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Code looks generally good. You need to manage the integration with Mirco's star branch :-) Which has landed in trunk I think.
Kudos for the autopilot tests.
John to confirm behaviour.