Merge lp://qastaging/~azzar1/unity/other-dnd-fixes into lp://qastaging/unity
Proposed by
Andrea Azzarone
| Status: | Merged |
|---|---|
| Approved by: | Jason Smith |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 1510 |
| Proposed branch: | lp://qastaging/~azzar1/unity/other-dnd-fixes |
| Merge into: | lp://qastaging/unity |
| Diff against target: |
255 lines (+74/-22) 6 files modified
plugins/unityshell/src/DNDCollectionWindow.cpp (+40/-7) plugins/unityshell/src/DNDCollectionWindow.h (+10/-2) plugins/unityshell/src/Launcher.cpp (+19/-12) plugins/unityshell/src/Launcher.h (+1/-0) plugins/unityshell/src/LauncherModel.cpp (+3/-0) plugins/unityshell/src/PluginAdapter.h (+1/-1) |
| To merge this branch: | bzr merge lp://qastaging/~azzar1/unity/other-dnd-fixes |
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jason Smith (community) | Approve | ||
|
Review via email:
|
|||
Commit message
This branch tries to solve some dnd bugs.
1) First it try to remove the extra mouse movement that sometimes is required by DNDCollectionWindow using another timeout of 50ms and the XWarpPointer function. To avoid the extra movement also when we are in "Dash View" we need to restack the window every time and not only inside the constructor.
2) Makes it possible to dnd a USB key even if it is the only device icon in launcher.
3) Makes it possible to add more .desktop file into the launcher at once (use /usr/share/
To post a comment you must log in.
Revision history for this message
| Andrea Azzarone (azzar1) wrote | # |
Revision history for this message
| Andrea Azzarone (azzar1) wrote | # |
Revision history for this message
| Andrea Azzarone (azzar1) wrote | # |
Revision history for this message
| Andrea Azzarone (azzar1) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
We can't leak CompScreen into more classes. This makes testing VERY difficult down the road. Try to minimize your actual dependencies in the class. Looks like what you really need is a Display* from Xlib.