Unity

launcher/FileManagerLauncherIcon.cpp (+30/-0)
launcher/FileManagerLauncherIcon.h (+8/-0)
launcher/StorageLauncherIcon.cpp (+7/-12)
tests/CMakeLists.txt (+1/-0)
tests/test_file_manager_launcher_icon.cpp (+202/-0)

To merge this branch:

bzr merge lp://qastaging/~azzar1/unity/properly-handle-copy-dialog

Related bugs:

Bug #1575452: Copy/move dialog cannot be switched to in Xenial	High	Fix Released
Bug #1609845: sudo ubuntu-sdk ... open project ... click to file right key mouse "Show Containing Folder" . a folder shortcut in unity sidebar is not active	Medium	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Marco Trevisan (Treviño)		2016-07-06	Approve on 2016-11-07
PS Jenkins bot	continuous-integration		Pending
Review via email: mp+299301@code.qastaging.launchpad.net

Commit message

Properly handle the file manager copy dialog in FileManagerLauncherIcon and in StorageLauncherIcon.

Revision history for this message

Marco Trevisan (Treviño) (3v1n0) wrote on 2016-11-03:

Sorry for being late, but... Yeah, although I'd like to get rid of that WindowManager::Default().IsWindowMapped(app_win->window_id()) check, I know that there are multiple races involved there, so we can't probably avoid it.

Just wondering if it could happen that the mapping would happen afterwards and we'd miss a window because there's no other signal catching that (and compiz might not signal us anything)...

But things work ok with this, so let's put it in production.

review: Approve

Revision history for this message

Marco Trevisan (Treviño) (3v1n0) wrote on 2016-11-04:

Ouch, there are merging issues with trunk... Please fix this.

review: Needs Fixing

Revision history for this message

Andrea Azzarone (azzar1) wrote on 2016-11-07:

> Ouch, there are merging issues with trunk... Please fix this.

Done.

Revision history for this message

Marco Trevisan (Treviño) (3v1n0) wrote on 2016-11-07:

Ok, thanks!

review: Approve

Revision history for this message

Amr Ibrahim (amribrahim1987) wrote on 2017-06-22:

The related bugs were reported against Xenial but there were not fixed there. Please push this fix to Xenial. Users are still affected in 16.04. Have a look at bug #1399077 and its duplicates.