Merge lp://qastaging/~azzar1/unity/scale-eject-notification into lp://qastaging/unity

Proposed by Andrea Azzarone
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: no longer in the source branch.
Merged at revision: 4157
Proposed branch: lp://qastaging/~azzar1/unity/scale-eject-notification
Merge into: lp://qastaging/unity
Diff against target: 140 lines (+10/-32)
6 files modified
launcher/DeviceNotificationDisplay.h (+1/-1)
launcher/DeviceNotificationDisplayImp.cpp (+4/-26)
launcher/DeviceNotificationDisplayImp.h (+1/-1)
launcher/VolumeLauncherIcon.cpp (+1/-1)
tests/test_mock_devices.h (+1/-1)
tests/test_volume_launcher_icon.cpp (+2/-2)
To merge this branch: bzr merge lp://qastaging/~azzar1/unity/scale-eject-notification
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
Review via email: mp+300757@code.qastaging.launchpad.net

Commit message

Use the standard notification-device-eject in the "device eject" notification. This allows us to scale it properly on high-dpi setups.

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

not a code review but you have a typo in the commit message "notificaiton"

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Yeah, better one.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.