Unity 8

Merge lp://qastaging/~azzar1/unity8/ql-list-windows into lp://qastaging/unity8

  1. ql-list-windows
  2. Merge into trunk
Proposed by Andrea Azzarone
Status: Work in progress
Proposed branch: lp://qastaging/~azzar1/unity8/ql-list-windows
Merge into: lp://qastaging/unity8
Prerequisite: lp://qastaging/~dandrader/unity8/consolidateLauncherAPIChecks
Diff against target: 461 lines (+185/-14)
13 files modified
CMakeLists.txt (+1/-1)
debian/control (+2/-2)
plugins/Unity/Launcher/CMakeLists.txt (+2/-0)
plugins/Unity/Launcher/launcheritem.cpp (+87/-1)
plugins/Unity/Launcher/launcheritem.h (+15/-3)
plugins/Unity/Launcher/launchermodel.cpp (+15/-0)
plugins/Unity/Launcher/quicklistentry.cpp (+11/-0)
plugins/Unity/Launcher/quicklistentry.h (+4/-0)
plugins/Unity/Launcher/quicklistmodel.cpp (+36/-7)
plugins/Unity/Launcher/quicklistmodel.h (+6/-0)
qml/Launcher/LauncherPanel.qml (+2/-0)
tests/mocks/Unity/Launcher/MockQuickListModel.cpp (+2/-0)
tests/plugins/Unity/Launcher/CMakeLists.txt (+2/-0)
To merge this branch: bzr merge lp://qastaging/~azzar1/unity8/ql-list-windows
Reviewer Review Type Date Requested Status
Unity8 CI Bot continuous-integration Needs Fixing
Lukáš Tinkl Pending
Review via email: mp+316735@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2017-01-30.

Commit message

Add window list to quicklist.

Description of the change

 * Are there any related MPs required for this MP to build/function as expected?

Yes. https://code.launchpad.net/~azzar1/unity-api/add-visible-role

 * Did you perform an exploratory manual test run of your code change and any related functionality?

Yes.

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

Yes.

 * If you changed the UI, has there been a design review?

Same design as u7.

To post a comment you must log in.
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2801
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3100/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/4029/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4057
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3901/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3901/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3901/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3901/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3901/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3901/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3100/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Lukáš Tinkl (lukas-kde) wrote : Posted in a previous version of this proposal

Please resubmit on top of lp:~dandrader/unity8/consolidateLauncherAPIChecks, it will most likely cause conflicts otherwise

review: Needs Fixing
Revision history for this message
Andrea Azzarone (azzar1) wrote : Posted in a previous version of this proposal

> Please resubmit on top of lp:~dandrader/unity8/consolidateLauncherAPIChecks,
> it will most likely cause conflicts otherwise

Done.

Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2802
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3111/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/4046/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4074
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3919/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3919/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3919/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3919/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3919/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3919/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3111/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Albert Astals Cid (aacid) wrote :

Text conflict in CMakeLists.txt
1 conflicts encountered.

Reply
Revision history for this message
Albert Astals Cid (aacid) wrote :

A month without merging → WiP

Reply

Unmerged revisions

2802. By Andrea Azzarone

Merge with lp:~dandrader/unity8/consolidateLauncherAPIChecks

2801. By Andrea Azzarone

Add a window list section to a quicklist.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches