lp://qastaging/~bac/juju-quickstart/ssh-agent

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://qastaging/juju-quickstart at revision 53

Madison Scott-Clary (community): Approve on 2014-01-31

Diff: 220 lines (+64/-30)

3 files modified

Makefile (+4/-0)
quickstart/app.py (+7/-0)
quickstart/tests/test_app.py (+53/-30)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1274164: Existing ssh-agent process not used

High

Fix Released

Link a bug report

Related blueprints

54. By Brad Crittenden on 2014-01-31

Avoid calling system ssh-agent in tests

53. By Brad Crittenden on 2014-01-31

Merge from trunk

52. By Brad Crittenden on 2014-01-31

Use existing ssh-agent if one is alive and well.

51. By Francesco Banconi on 2014-01-30

Minor fixes to code comments and documentation

Also fixed a possible encoding problem in error handling.

The get_admin_secret function and its test case are just moved, no
need to re-review.

Tests: `make check`.
No QA.

R=bac
CC=
https://codereview.appspot.com/58680043

50. By Brad Crittenden on 2014-01-29

Get admin_secret from juju-generated jenv file.

As of Juju v 1.17 the admin-secret is stored in a generated file, located in
$JUJU_HOME/environments/<environment>.jenv.

If an admin-secret is provided in environments.yaml, it is used and also
stored in the jenv file. If none is given, then juju fabricates one and
stores it in the jenv file.

The admin-secret *field* is marked as optional now. For the case where a
local environment is used, Quickstart previously would generate an
admin-secret. That behavior is maintained by forcing 'admin-secret' to be in
the missing_fields list. This approach ensures backwards compatibility.

Note that the Juju-generated admin-secret is not available until after
bootstrapping the environment. Due to this behavior, when using juju v1.16
and not admin-secret is configured in the environments.yaml file, the failure
will not be reported until after bootstrapping. This approach seemed better
than introducing hard version checking.

R=frankban
CC=
https://codereview.appspot.com/57900043

49. By Francesco Banconi on 2014-01-29

Update for PyPI release.

R=gary.poster
CC=
https://codereview.appspot.com/51790045

48. By Francesco Banconi on 2014-01-20

Support the new juju switch behavior.

Quickstart is now able to retrieve the
default environment name in newer
versions of juju-core.

Tests: `make check`.
No QA required.

R=gary.poster
CC=
https://codereview.appspot.com/54560043

47. By Francesco Banconi on 2014-01-17

Improve machine errors handling.

Quickstart no longer hangs when the GUI
machine goes in an "error" state and, as
a consequence, the unit is forever in
a "pending" state.

Also fixed the message printed at the
end of the process suggesting how to
destroy the environment
(sudo is used where required).

Tests: `make check`.

QA: I already asked Rick to reproduce the trusty/LXC
errors he encountered QAing my previous branch.
The GUI no longer hangs.
I'd also appreciate any other suggestion and additional
QA, given that this branch is a good candidate for 1.0.

R=bac, rharding
CC=
https://codereview.appspot.com/51350044

46. By Francesco Banconi on 2014-01-16

Add support for OpenStack and Azure.

Tests: `make check`

QA: `.venv/bin/python juju-quickstart -i`
Ensure you can successfully create an openstack/HP cloud
and an azure environment.
If you already subscribed to any of those, please
check everything works ok. If not, no problem,
I already bootstrapped HP Cloud and azure.
Since this is the 1.0 version, please ensure
the environment management works well, and in general
quickstart bootstraps the environments and
deploys the GUI as expected.
Thank you!

R=rharding, matthew.scott
CC=
https://codereview.appspot.com/52080044

45. By Francesco Banconi on 2014-01-14

Create a backup copy of the envs file.

In a pre-imp call with Gary, we decided the
following strategy: a backup copy of the
environments.yaml file is created once per
quickstart session the first time environments
are changed by the user. This way we prevent the
original backup to be overwritten if the user
makes two subsequent changes to the envs.

Tests: `make check`.

QA:

- Create a backup copy of your environments file:
  `cp ~/.juju/environments.yaml ~/environments.yaml.bak`.

- Run `.venv/bin/python juju-quickstart -i`, select one
  of your environments, exit with ^X without changing anything.
  Check your original file has not been changed.

- Run `.venv/bin/python juju-quickstart -i`, change something
  (e.g. create, remove or change an environment, or just change
  the default one). Change at least two environments.
  Exit with ^X. The envs.yaml file now should be the one
  generated by quickstart and should reflect your changes.
  It also includes the path to the backup copy, which
  should be your original file.

- Restore your original environments file:
  `mv ~/environments.yaml.bak ~/.juju/environments.yaml`.

Done, thank you!

R=
CC=
https://codereview.appspot.com/51520043