Merge lp://qastaging/~bac/launchpad/bug-32618 into lp://qastaging/launchpad

Hi Brad.

I love your proposed soltution that made this issue a trival problem. I see your editor converted a tab into a spaces :).

I have an optional request. I see that the save() method is doing validation /after/ it starts making changes to the jabber ids. I think we should move the validation code to a validate mthod and make the save() method only do changes. I see there are already tests showing the expected behaviour, and I expect this proposed refactoring to pass:

    def validate(self, data):
        jabberid = data.get('newjabberid')
        if jabberid is not None:
            jabberset = getUtility(IJabberIDSet)
            existingjabber = jabberset.getByJabberID(jabberid)
            if existingjabber.person != self.context:
                self.request.response.addErrorNotification(
                    structured(
                        'The Jabber ID %s is already registered by '
                        '<a href="%s">%s</a>.',
                        jabberid, canonical_url(existingjabber.person),
                        existingjabber.person.displayname))
            else:
                self.request.response.addErrorNotification(
                    'The Jabber ID %s already belongs to you.' % jabberid)
...
    @action(_("Save Changes"), name="save")
    def save(self, action, data):
...
        jabberid = form.get('newjabberid')
        if jabberid is not None:
            jabberset.new(self.context, jabberid)

Thanks for the comments, Curtis. I converted the form to be a proper LaunchpadFormView with the validation method. This also fixed bug 615872.

Incremental at http://pastebin.ubuntu.com/475950/

I did not mean to cause any consternation. I really appreciate your fix to this old code and that this also addresses another bug.