Merge lp://qastaging/~bac/launchpad/bug-487793 into lp://qastaging/launchpad

= Summary =

A new portlet to show information about a distroseries' upstream packaging
associations is shown on the distroseries-index page.

== Proposed fix ==

Create a new portlet showing the most recently linked packages and those that most
need attention, either linking or providing additional information like bug tracker
location, etc.

== Pre-implementation notes ==

Talks with Curtis.

== Implementation details ==

As above.

== Tests ==

bin/test -vvm lp.registry -t distroseries.txt -t xx-distroseries-index.txt

== Demo and Q/A ==

https://launchpad.dev/ubuntu/warty
https://launchpad.dev/ubuntu/warty
https://launchpad.net/ubuntu/lucid

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/registry/browser/configure.zcml
  lib/lp/registry/templates/distroseries-portlet-packaging.pt
  lib/lp/registry/templates/distroseries-index.pt
  lib/lp/blueprints/browser/specificationtarget.py
  lib/lp/registry/doc/distroseries.txt
  lib/lp/registry/interfaces/distroseries.py
  BRANCH.TODO
  lib/lp/registry/stories/distroseries/xx-distroseries-index.txt
  lib/lp/registry/model/distroseries.py
  lib/lp/registry/browser/distroseries.py
  lib/lp/soyuz/templates/distroseries-portlet-latestuploads.pt

== Pylint notices ==

lib/lp/registry/interfaces/distroseries.py
    23: [F0401] Unable to import 'lazr.enum' (No module named enum)
    50: [F0401] Unable to import 'lazr.restful.fields' (No module named restful)
    51: [F0401] Unable to import 'lazr.restful.declarations' (No module named restful)
    116: [E1002, DistroSeriesVersionField._validate] Use super on an old style class
    452: [C0322, IDistroSeriesPublic.getPackageUploads] Operator not preceded by a space
    description=_("Return items that are more recent than this "
    ^
    "timestamp."),
    required=False),
    status=Choice(

    vocabulary=DBEnumeratedType,
    title=_("Package Upload Status"),
    description=_("Return only items that have this status."),
    required=False),
    archive=Reference(

    schema=Interface,
    title=_("Archive"),
    description=_("Return only items for this archive."),
    required=False),
    pocket=Choice(

    vocabulary=DBEnumeratedType,
    title=_("Pocket"),
    description=_("Return only items targeted to this pocket"),
    required=False),
    custom_type=Choice(

    vocabulary=DBEnumeratedType,
    title=_("Custom Type"),
    description=_("Return only items with custom files of this "
    "type."),
    required=False),
    )

    @operation_returns_collection_of(Interface)
    @export_read_operation()
    def getPackageUploads(created_since_date, status, archive, pocket,
    custom_type):

lib/lp/registry/model/distroseries.py
    478: [W0105, DistroSeries.getMostRecentlyLinkedPackagings] String statement has
no effect

The last lint issue will be fixed before landing.

Also a number of drive-by typos will be fixed before landing. The diff is at:
http://pastebin.ubuntu.com/379696/

Priorized -> Prioritized (in two method names)
prioritised -> prioritzed (use en_US)
pakage -> package

Hi Brad,

a nice branch! Thanks for all the drve-by cleanups!

I have just one minor suggestion, see below.

Abel

> === modified file 'lib/lp/registry/model/distroseries.py'
> --- lib/lp/registry/model/distroseries.py 2010-01-21 18:09:05 +0000
> +++ lib/lp/registry/model/distroseries.py 2010-02-19 12:22:16 +0000
> @@ -315,9 +315,9 @@
> result += self.distribution.name + self.name
> return result
>
> - @property
> - def packagings(self):
> - """See `IDistroSeries`."""
> + @cachedproperty
> + def _all_packagings(self):
> + """Get an unordered list of all packagings."""
> # We join to SourcePackageName, ProductSeries, and Product to cache
> # the objects that are implicitly needed to work with a
> # Packaging object.
> @@ -338,6 +338,12 @@
> ProductSeries.product == Product.id)]
> condition = [Packaging.distroseries == self.id]
> results = IStore(self).using(*origin).find(find_spec, *condition)
> + return results

Since the list 'condition' will never change in this method, I think this can be simplified to

          condition = Packaging.distroseries == self.id
          results = IStore(self).using(*origin).find(find_spec, condition)

Abel thanks for your suggestion. Unfortunately the condition has to be a sequence. Since it is immutable I could make it a tuple instead of a list but that would look like:

condition = (Packaging.distroseries == self.id, )

which I personally to be more distracting than just using a list. So unless you have strong objections I'd prefer to leave the code as is.

On 19.02.2010 16:35, Brad Crittenden wrote:
> Abel thanks for your suggestion. Unfortunately the condition has to be a sequence. Since it is immutable I could make it a tuple instead of a list but that would look like:
>
> condition = (Packaging.distroseries == self.id, )
>
> which I personally to be more distracting than just using a list. So unless you have strong objections I'd prefer to leave the code as is.

Sure, having a tuple there would be more distracting. But, well, perhaps
I am a bit thick today, and out of curiosity -- what is wrong with

        condition = Packaging.distroseries == self.id
        results = IStore(self).using(*origin).find(find_spec, condition)
        return results

I just tried the tests with this variant -- it passed just fine.

Abel

Abel thanks for the follow up. It was me being dense, not you!

When I'd attempted to make the change earlier I failed to remove the * from *condition when passing the parameter.

I've made the improvement now as you suggest.

Hi Brad.

Thanks for working on this. Thanks for finalising my mistmatched suggestions.

There is a link problem. I see (i) Show uploads in the new portlet. It should have remained with the Latest uploads portlet that was moved below the milestones. We expect the user to see the latest uploads, then use the (i) Show uploads link to see the uploads that are not listed.

The new portlet is showing linked and unlinked packagings, and each has its own report. We want the new portlet to link to these reports: (i) Needs upstream links (i) All upstream links. Note that each report links to its counterpart so that the user does not need to return to the portlet.

This is fine to land after to reconcile the links.

Oh wow, I just used Edwin's link source package to upstream project multi-step form. That was nice. That is much faster than the series picker. I see that users are shown when they set the package...sample data sucks.