Code review comment for lp://qastaging/~bac/launchpad/bug-487793

On 19.02.2010 16:35, Brad Crittenden wrote:
> Abel thanks for your suggestion. Unfortunately the condition has to be a sequence. Since it is immutable I could make it a tuple instead of a list but that would look like:
>
> condition = (Packaging.distroseries == self.id, )
>
> which I personally to be more distracting than just using a list. So unless you have strong objections I'd prefer to leave the code as is.

Sure, having a tuple there would be more distracting. But, well, perhaps
I am a bit thick today, and out of curiosity -- what is wrong with

        condition = Packaging.distroseries == self.id
        results = IStore(self).using(*origin).find(find_spec, condition)
        return results

I just tried the tests with this variant -- it passed just fine.

Abel